fix(profiling): disable wall/cpu on some PHP 8.5 builds#3889
Draft
morrisonlevi wants to merge 6 commits into
Draft
fix(profiling): disable wall/cpu on some PHP 8.5 builds#3889morrisonlevi wants to merge 6 commits into
morrisonlevi wants to merge 6 commits into
Conversation
|
Benchmarks [ profiler ]Benchmark execution time: 2026-05-21 18:35:49 Comparing candidate commit 5a44a85 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics. |
1a222c9 to
80530b1
Compare
realFlowControl
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables the wall- and cpu-time sample types of the profiler on PHP 8.5.0 through 8.5.6 (inclusive) so it doesn't trigger the tailcall VM vm_interrupt crash fixed in the upcoming PHP 8.5.7 release.
Technically, anything which sets the
vm_interruptcan trigger this crash, such the tracer and even PHP itself with its timeout limit. However, the profiler sets it all the time (roughly every 10 ms) with its wall- and cpu-time sample types, so it is the most common trigger.Affected customers:
You can check your PHP version and VM kind with:
php -r 'echo PHP_VERSION, "\n", (defined("ZEND_VM_KIND") ? ZEND_VM_KIND : "undef"), "\n";'Reviewer checklist