-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: DataDog/go-runtime-metrics-internal
base: 81009b9
head repository: DataDog/go-runtime-metrics-internal
compare: fdf1ef8
- 19 commits
- 7 files changed
- 2 contributors
Commits on Jun 3, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7edb7c2 - Browse repository at this point
Copy the full SHA 7edb7c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 478a842 - Browse repository at this point
Copy the full SHA 478a842View commit details
Commits on Jun 25, 2025
-
chore: remove toolchain directive from go.mod
IDK where it was there to begin with. The [go module spec][1] says: > The toolchain directive only has an effect when the module is the main > module and the default toolchain’s version is less than the suggested > toolchain’s version. So removing this should not have any impact. [1]: https://go.dev/ref/mod#go-mod-file-toolchain
Configuration menu - View commit details
-
Copy full SHA for aa78e0d - Browse repository at this point
Copy the full SHA aa78e0dView commit details -
chore: upgrade go.mod go directive to 1.23
This brings us inline with the minimal go version required by dd-trace-go and also allows using `cmp.Or` which is introduced by a later commit in this PR.
Configuration menu - View commit details
-
Copy full SHA for ca40190 - Browse repository at this point
Copy the full SHA ca40190View commit details
Commits on Jun 28, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7914529 - Browse repository at this point
Copy the full SHA 7914529View commit details
Commits on Jul 3, 2025
-
Merge pull request #18 from DataDog/push-ltsptlnlnkpt
feat: Add new Emitter API to start and stop metrics
Configuration menu - View commit details
-
Copy full SHA for bb83ff2 - Browse repository at this point
Copy the full SHA bb83ff2View commit details -
This test was passing entirely by accident in the past because `/sync/mutex/wait/total:seconds` was typically not zero by the time was getting executed.
Configuration menu - View commit details
-
Copy full SHA for 0f993a6 - Browse repository at this point
Copy the full SHA 0f993a6View commit details -
fix: resolve race condition in statsdClientMock
Add proper synchronization to statsdClientMock to prevent data races between concurrent reads and writes to the call slices. The race occurred when the emitter goroutine was writing to the slices while the test goroutine was reading from them. Changes: - Add sync.RWMutex to statsdClientMock struct - Protect all slice writes with write locks in GaugeWithTimestamp, CountWithTimestamp, and DistributionSamples methods - Add thread-safe getter methods (GaugeCalls, CountCalls, DistributionSampleCalls) that return copies under read lock - Update all test code to use the new thread-safe getter methods instead of direct slice access Fixes race condition detected by 'go test -race'
Configuration menu - View commit details
-
Copy full SHA for 1414815 - Browse repository at this point
Copy the full SHA 1414815View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27f362d - Browse repository at this point
Copy the full SHA 27f362dView commit details -
fix: ensure that no more statds calls are made after Emitter.Stop ret…
…urns This fixes flakiness in TestEmitter/should_emit_metrics.
Configuration menu - View commit details
-
Copy full SHA for 21429c9 - Browse repository at this point
Copy the full SHA 21429c9View commit details -
Merge pull request #19 from DataDog/push-pvkzwxmrvkns
fix test suite flakiness
Configuration menu - View commit details
-
Copy full SHA for 4af5851 - Browse repository at this point
Copy the full SHA 4af5851View commit details
Commits on Jul 4, 2025
-
feat: Limit NewEmitter to one instance by default
Change the API of NewEmitter to return an error when there is more than one instance running already. Add an AllowMultipleInstances in case we have a need for running multiple instances at some point for some reason. This paves the path for reintroducing the old Start() API and is probably also a good idea in general.
Configuration menu - View commit details
-
Copy full SHA for 87af3af - Browse repository at this point
Copy the full SHA 87af3afView commit details -
chore: Restore old Start() API, but mark as deprecated
This might help with upgrading some of our internal systems.
Configuration menu - View commit details
-
Copy full SHA for bda26a0 - Browse repository at this point
Copy the full SHA bda26a0View commit details
Commits on Jul 5, 2025
-
Configuration menu - View commit details
-
Copy full SHA for ee60b18 - Browse repository at this point
Copy the full SHA ee60b18View commit details
Commits on Jul 7, 2025
-
* tags: restore SetBaseTags() which is also used internally * fix: only apply SetBaseTags for the Start() API (#23) --------- Co-authored-by: Felix Geisendörfer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee67302 - Browse repository at this point
Copy the full SHA ee67302View commit details
Commits on Jul 10, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 28b1f19 - Browse repository at this point
Copy the full SHA 28b1f19View commit details -
Merge pull request #24 from DataDog/push-osurnmmpsnvz
fix: NewEmitter panic if opts is nil and more than one instance is running
Configuration menu - View commit details
-
Copy full SHA for d3ee4f4 - Browse repository at this point
Copy the full SHA d3ee4f4View commit details
Commits on Jul 20, 2025
-
chore: hard code the list of supported metrics
Two reasons: 1. Exclude godebug metrics to keep costs under control. 2. Submitting new metrics requires back end changes to get the units right.
Configuration menu - View commit details
-
Copy full SHA for a042ce3 - Browse repository at this point
Copy the full SHA a042ce3View commit details
Commits on Jul 21, 2025
-
Merge pull request #25 from DataDog/push-snrtnsoysrzw
chore: hard code the list of supported metrics
Configuration menu - View commit details
-
Copy full SHA for fdf1ef8 - Browse repository at this point
Copy the full SHA fdf1ef8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 81009b9...fdf1ef8