Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DataDog/go-runtime-metrics-internal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 81009b9
Choose a base ref
...
head repository: DataDog/go-runtime-metrics-internal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fdf1ef8
Choose a head ref
  • 19 commits
  • 7 files changed
  • 2 contributors

Commits on Jun 3, 2025

  1. Configuration menu
    Copy the full SHA
    7edb7c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    478a842 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2025

  1. chore: remove toolchain directive from go.mod

    IDK where it was there to begin with. The [go module spec][1] says:
    
    > The toolchain directive only has an effect when the module is the main
    > module and the default toolchain’s version is less than the suggested
    > toolchain’s version.
    
    So removing this should not have any impact.
    
    [1]: https://go.dev/ref/mod#go-mod-file-toolchain
    felixge committed Jun 25, 2025
    Configuration menu
    Copy the full SHA
    aa78e0d View commit details
    Browse the repository at this point in the history
  2. chore: upgrade go.mod go directive to 1.23

    This brings us inline with the minimal go version required by
    dd-trace-go and also allows using `cmp.Or` which is introduced by a
    later commit in this PR.
    felixge committed Jun 25, 2025
    Configuration menu
    Copy the full SHA
    ca40190 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2025

  1. Configuration menu
    Copy the full SHA
    7914529 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. Merge pull request #18 from DataDog/push-ltsptlnlnkpt

    feat: Add new Emitter API to start and stop metrics
    felixge authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    bb83ff2 View commit details
    Browse the repository at this point in the history
  2. fix: incorrect assert

    This test was passing entirely by accident in the past because
    `/sync/mutex/wait/total:seconds` was typically not zero by the time was
    getting executed.
    felixge committed Jul 3, 2025
    Configuration menu
    Copy the full SHA
    0f993a6 View commit details
    Browse the repository at this point in the history
  3. fix: resolve race condition in statsdClientMock

    Add proper synchronization to statsdClientMock to prevent data races between
    concurrent reads and writes to the call slices. The race occurred when the
    emitter goroutine was writing to the slices while the test goroutine was
    reading from them.
    
    Changes:
    - Add sync.RWMutex to statsdClientMock struct
    - Protect all slice writes with write locks in GaugeWithTimestamp, CountWithTimestamp, and DistributionSamples methods
    - Add thread-safe getter methods (GaugeCalls, CountCalls, DistributionSampleCalls) that return copies under read lock
    - Update all test code to use the new thread-safe getter methods instead of direct slice access
    
    Fixes race condition detected by 'go test -race'
    felixge committed Jul 3, 2025
    Configuration menu
    Copy the full SHA
    1414815 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    27f362d View commit details
    Browse the repository at this point in the history
  5. fix: ensure that no more statds calls are made after Emitter.Stop ret…

    …urns
    
    This fixes flakiness in TestEmitter/should_emit_metrics.
    felixge committed Jul 3, 2025
    Configuration menu
    Copy the full SHA
    21429c9 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #19 from DataDog/push-pvkzwxmrvkns

    fix test suite flakiness
    felixge authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    4af5851 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2025

  1. feat: Limit NewEmitter to one instance by default

    Change the API of NewEmitter to return an error when there is more than
    one instance running already.
    
    Add an AllowMultipleInstances in case we have a need for running
    multiple instances at some point for some reason.
    
    This paves the path for reintroducing the old Start() API and is
    probably also a good idea in general.
    felixge committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    87af3af View commit details
    Browse the repository at this point in the history
  2. chore: Restore old Start() API, but mark as deprecated

    This might help with upgrading some of our internal systems.
    felixge committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    bda26a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2025

  1. Configuration menu
    Copy the full SHA
    ee60b18 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2025

  1. Restore SetBaseTags (#22)

    * tags: restore SetBaseTags() which is also used internally
    
    * fix: only apply SetBaseTags for the Start() API (#23)
    
    ---------
    
    Co-authored-by: Felix Geisendörfer <[email protected]>
    Gandem and felixge authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    ee67302 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2025

  1. Configuration menu
    Copy the full SHA
    28b1f19 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #24 from DataDog/push-osurnmmpsnvz

    fix: NewEmitter panic if opts is nil and more than one instance is running
    felixge authored Jul 10, 2025
    Configuration menu
    Copy the full SHA
    d3ee4f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2025

  1. chore: hard code the list of supported metrics

    Two reasons:
    
    1. Exclude godebug metrics to keep costs under control.
    2. Submitting new metrics requires back end changes to get the units
       right.
    felixge committed Jul 20, 2025
    Configuration menu
    Copy the full SHA
    a042ce3 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2025

  1. Merge pull request #25 from DataDog/push-snrtnsoysrzw

    chore: hard code the list of supported metrics
    felixge authored Jul 21, 2025
    Configuration menu
    Copy the full SHA
    fdf1ef8 View commit details
    Browse the repository at this point in the history
Loading