net/smc: Remove redundant refcount increase

Yacan Liu · Paolo Abeni · commit a8424a9b4522 · 2022-09-01T10:04:45.000+02:00
For passive connections, the refcount increment has been done in smc_clcsock_accept()-->smc_sock_alloc(). Fixes: 3b2dec2 ("net/smc: restructure client and server code in af_smc") Signed-off-by: Yacan Liu <liuyacan@corp.netease.com> Reviewed-by: Tony Lu <tonylu@linux.alibaba.com> Link: https://lore.kernel.org/r/20220830152314.838736-1-liuyacan@corp.netease.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
@@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
 {
 	struct sock *newsmcsk = &new_smc->sk;
 
-	sk_refcnt_debug_inc(newsmcsk);
 	if (newsmcsk->sk_state == SMC_INIT)
 		newsmcsk->sk_state = SMC_ACTIVE;
 

Original file line number	Diff line number	Diff line change
`@@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)`
`1855`	`1855`	`{`
`1856`	`1856`	`struct sock *newsmcsk = &new_smc->sk;`
`1857`	`1857`
`1858`		`- sk_refcnt_debug_inc(newsmcsk);`
`1859`	`1858`	`if (newsmcsk->sk_state == SMC_INIT)`
`1860`	`1859`	`newsmcsk->sk_state = SMC_ACTIVE;`
`1861`	`1860`