fix: scatter3d marker opacity when marker.opacity is set to 0

dmyronuk · dmyronuk · commit c104ed7a54dc · 2023-04-24T22:48:30.000-04:00
diff --git a/src/traces/scatter3d/convert.js b/src/traces/scatter3d/convert.js
@@ -1,5 +1,7 @@
 'use strict';
 
+var isNumeric = require('fast-isnumeric');
+
 var createLinePlot = require('../../../stackgl_modules').gl_line3d;
 var createScatterPlot = require('../../../stackgl_modules').gl_scatter3d;
 var createErrorBars = require('../../../stackgl_modules').gl_error3d;
@@ -403,7 +405,7 @@ proto.update = function(data) {
 
     // N.B. marker.opacity must be a scalar for performance
     var scatterOpacity = data.opacity;
-    if(data.marker && data.marker.opacity) scatterOpacity *= data.marker.opacity;
+    if(data.marker && isNumeric(data.marker.opacity)) scatterOpacity *= data.marker.opacity;
 
     scatterOptions = {
         gl: this.scene.glplot.gl,
diff --git a/test/jasmine/tests/scatter3d_test.js b/test/jasmine/tests/scatter3d_test.js
@@ -329,4 +329,21 @@ describe('Test scatter3d interactions:', function() {
         })
         .then(done, done.fail);
     });
+
+    it('@gl markers should be transparent when marker.opacity is 0', function(done) {
+        Plotly.newPlot(gd, [
+            {
+                type: 'scatter3d',
+                x: [0],
+                y: [0],
+                z: [0],
+                mode: 'markers',
+                marker: { opacity: 0 }
+            },
+        ])
+        .then(function() {
+            expect(gd._fullLayout.scene._scene.glplot.objects[0].opacity).toEqual(0);
+        })
+        .then(done, done.fail);
+    });
 });
