fix to_image test paths

jonmmease · jonmmease · commit d9d9142cf7ae · 2019-06-05T12:02:18.000-04:00
diff --git a/plotly-package/plotly/tests/test_orca/test_to_image.py b/plotly-package/plotly/tests/test_orca/test_to_image.py
@@ -1,3 +1,4 @@
+import plotly
 import plotly.io as pio
 import plotly.graph_objs as go
 import os
@@ -13,20 +14,21 @@
 
 # Constants
 # ---------
-images_root = 'plotly/tests/test_orca/images/'
-
+project_root = os.path.dirname(os.path.realpath(plotly.__file__))
+images_root = os.path.join(project_root, 'tests', 'test_orca', 'images')
+print(images_root)
 if sys.platform.startswith('linux'):
-    images_dir = images_root + 'linux/'
+    images_dir = os.path.join(images_root, 'linux')
 elif sys.platform == 'darwin':
-    images_dir = images_root + 'darwin/'
+    images_dir = os.path.join(images_root, 'darwin')
 else:
     raise ValueError(
         'No reference images available for platform: {platform}'
         .format(platform=sys.platform))
 
 
-failed_dir = images_dir + 'failed/'
-tmp_dir = images_dir + 'tmp/'
+failed_dir = os.path.join(images_dir, 'failed/')
+tmp_dir = os.path.join(images_dir, 'tmp/')
 # These formats are deterministic. PDF and svg don't seem to be
 image_formats = ['eps']
 
@@ -157,7 +159,7 @@ def latexfig():
 # Utilities
 # ---------
 def assert_image_bytes(img_bytes, file_name, _raise=True):
-    expected_img_path = images_dir + file_name
+    expected_img_path = os.path.join(images_dir, file_name)
 
     try:
         with open(expected_img_path, 'rb') as f:
@@ -166,7 +168,7 @@ def assert_image_bytes(img_bytes, file_name, _raise=True):
         assert expected == img_bytes
 
     except (OSError, AssertionError) as e:
-        failed_path = failed_dir + file_name
+        failed_path = os.path.join(failed_dir, file_name)
         print('Saving failed image to "{failed_path}"'
               .format(failed_path=failed_path))
 
@@ -199,13 +201,13 @@ def test_write_image_string(fig1, format):
     file_name = 'fig1.' + format
     file_path = tmp_dir + file_name
 
-    pio.write_image(fig1, tmp_dir + file_name,
+    pio.write_image(fig1, os.path.join(tmp_dir, file_name),
                     format=format, width=700, height=500)
 
     with open(file_path, 'rb') as f:
         written_bytes = f.read()
 
-    with open(images_dir + file_name, 'rb') as f:
+    with open(os.path.join(images_dir, file_name), 'rb') as f:
         expected_bytes = f.read()
 
     assert written_bytes == expected_bytes
@@ -214,7 +216,7 @@ def test_write_image_string(fig1, format):
 def test_write_image_writeable(fig1, format):
 
     file_name = 'fig1.' + format
-    with open(images_dir + file_name, 'rb') as f:
+    with open(os.path.join(images_dir, file_name), 'rb') as f:
         expected_bytes = f.read()
 
     mock_file = MagicMock()
@@ -227,54 +229,54 @@ def test_write_image_writeable(fig1, format):
 def test_write_image_string_format_inference(fig1, format):
     # Build file paths
     file_name = 'fig1.' + format
-    file_path = tmp_dir + file_name
+    file_path = os.path.join(tmp_dir, file_name)
 
     # Use file extension to infer image type.
-    pio.write_image(fig1, tmp_dir + file_name,
+    pio.write_image(fig1, os.path.join(tmp_dir, file_name),
                     width=700, height=500)
 
     with open(file_path, 'rb') as f:
         written_bytes = f.read()
 
-    with open(images_dir + file_name, 'rb') as f:
+    with open(os.path.join(images_dir, file_name), 'rb') as f:
         expected_bytes = f.read()
 
     assert written_bytes == expected_bytes
 
 
 def test_write_image_string_no_extension_failure(fig1):
     # No extension
-    file_path = tmp_dir + 'fig1'
+    file_path = os.path.join(tmp_dir, 'fig1')
 
     # Use file extension to infer image type.
     with pytest.raises(ValueError) as err:
-        pio.write_image(fig1, file_path + 'fig1')
+        pio.write_image(fig1, os.path.join(file_path, 'fig1'))
 
     assert 'add a file extension or specify the type' in str(err.value)
 
 
 def test_write_image_string_bad_extension_failure(fig1):
     # Bad extension
-    file_path = tmp_dir + 'fig1.bogus'
+    file_path = os.path.join(tmp_dir, 'fig1.bogus')
 
     # Use file extension to infer image type.
     with pytest.raises(ValueError) as err:
-        pio.write_image(fig1, file_path + 'fig1')
+        pio.write_image(fig1, os.path.join(file_path, 'fig1'))
 
     assert 'must be specified as one of the following' in str(err.value)
 
 
 def test_write_image_string_bad_extension_override(fig1):
     # Bad extension
     file_name = 'fig1.bogus'
-    tmp_path = tmp_dir + file_name
+    tmp_path = os.path.join(tmp_dir, file_name)
 
     pio.write_image(fig1, tmp_path, format='eps', width=700, height=500)
 
     with open(tmp_path, 'rb') as f:
         written_bytes = f.read()
 
-    with open(images_dir + 'fig1.eps', 'rb') as f:
+    with open(os.path.join(images_dir, 'fig1.eps'), 'rb') as f:
         expected_bytes = f.read()
 
     assert written_bytes == expected_bytes
