Issue #1542 Bug fix case sensitivity of periods keyword in iMOD project file. (#1543)

verkaik · web-flow · commit 5ca60870686a · 2025-05-27T13:39:18.000+02:00
Fixes #1542 # Description  This fixes a minor bug related to unwanted case sensitivity of the periods keyword in the iMOD project file. # Checklist  - [x] Links to correct issue - [x] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [x] Unit tests were added - [ ] **If feature added**: Added/extended example
diff --git a/docs/api/changelog.rst b/docs/api/changelog.rst
@@ -46,6 +46,8 @@ Fixed
 - Fixed bug in :meth:`imod.mf6.Well.cleanup` and
   :meth:`imod.mf6.LayeredWell.cleanup` which caused an error when called with an
   unstructured discretization.
+- Fixed bug in :func:`imod.formats.prj.open_projectfile_data` which caused an
+  error when a periods keyword was used having an upper case.
 
 Changed
 ~~~~~~~
diff --git a/imod/formats/prj/prj.py b/imod/formats/prj/prj.py
@@ -1052,7 +1052,7 @@ def open_projectfile_data(path: FilePath) -> tuple[dict[str, Any], dict[str, Any
         # Set the year of a repeat date to 1899: this ensures it falls outside
         # of the iMOD calendar. Collisions are then always avoided.
         periods = {
-            key: _process_time(time, yearfirst=False).replace(year=1899)
+            key.lower(): _process_time(time, yearfirst=False).replace(year=1899)
             for key, time in periods_block.items()
         }
 
diff --git a/imod/tests/test_formats/test_prj.py b/imod/tests/test_formats/test_prj.py
@@ -82,10 +82,10 @@
     1900-01-01
     001,001
         1,2, 001, 1.0, 0.0, -999.9900,"{basepath}/rch.idf",
-    summer
+    SUMMER
     001,001
         1,2, 001, 1.0, 0.0, -999.9900,"{basepath}/rch.idf",
-    winter
+    WINTER
     001,001
         1,2, 001, 1.0, 0.0, -999.9900,"{basepath}/rch.idf",
 
@@ -109,9 +109,9 @@
         QERROR=  0.1000000
 
     Periods
-    summer
+    SUMMER
     01-04-1900 00:00:00
-    winter
+    WINTER
     01-10-1900 00:00:00
 
     Species

Original file line number	Diff line number	Diff line change
`@@ -1052,7 +1052,7 @@ def open_projectfile_data(path: FilePath) -> tuple[dict[str, Any], dict[str, Any`
`1052`	`1052`	`# Set the year of a repeat date to 1899: this ensures it falls outside`
`1053`	`1053`	`# of the iMOD calendar. Collisions are then always avoided.`
`1054`	`1054`	`periods = {`
`1055`		`- key: _process_time(time, yearfirst=False).replace(year=1899)`
	`1055`	`+ key.lower(): _process_time(time, yearfirst=False).replace(year=1899)`
`1056`	`1056`	`for key, time in periods_block.items()`
`1057`	`1057`	`}`
`1058`	`1058`