Issue #1498 mf6 Package: copy method is broken (#1505)

verkaik · JoerivanEngelen · web-flow · commit e1df40e7150d · 2025-04-17T16:36:38.000+02:00
Fixes #1498 # Description Fix broken copy method # Checklist  - [x] Links to correct issue - [x] Update changelog, if changes affect users - [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [x] Unit tests were added - [ ] **If feature added**: Added/extended example --------- Co-authored-by: JoerivanEngelen <joerivanengelen@hotmail.com>
diff --git a/docs/api/changelog.rst b/docs/api/changelog.rst
@@ -26,6 +26,7 @@ Fixed
   :meth:`imod.mf6.GeneralHeadBoundary.clip_box` threw an error when
   ``time_start`` or ``time_end`` were set to ``None`` and a ``"repeat_stress"``
   was included in the dataset.
+- Fixed bug where :meth:`imod.mf6.package.copy` threw an error.
 - Sorting issue in :func:`imod.prepare.assign_wells`. This could cause
   :class:`imod.mf6.Well` to assign wells to the wrong cells.
 - Fixed crash upon calling :meth:`imod.mf6.Well.clip_box` when the top/bottom
diff --git a/imod/mf6/package.py b/imod/mf6/package.py
@@ -372,7 +372,8 @@ def _validate_init_schemata(self, validate: bool):
 
     def copy(self) -> Any:
         # All state should be contained in the dataset.
-        return type(self)(**self.dataset.copy().to_dict())
+        dataset_copy = cast(Mapping[str, Any], self.dataset.copy())
+        return type(self)(**dataset_copy)
 
     def clip_box(
         self,
diff --git a/imod/tests/test_mf6/test_mf6_chd.py b/imod/tests/test_mf6/test_mf6_chd.py
@@ -73,6 +73,15 @@ def test_render(head):
     assert actual == expected
 
 
+def test_copy(head):
+    chd = imod.mf6.ConstantHead(
+        head, print_input=True, print_flows=True, save_flows=True
+    )
+    chd2 = chd.copy()
+    assert isinstance(chd2, ConstantHead)
+    assert chd2.dataset.equals(chd.dataset)
+
+
 def test_from_file(head, tmp_path):
     directory = pathlib.Path("mymodel")
     globaltimes = np.array(["2000-01-01"], dtype="datetime64[ns]")
diff --git a/imod/tests/test_mf6/test_mf6_dis.py b/imod/tests/test_mf6/test_mf6_dis.py
@@ -76,6 +76,15 @@ def test_render(idomain_and_bottom):
     assert actual == expected
 
 
+def test_copy(idomain_and_bottom):
+    idomain, bottom = idomain_and_bottom
+
+    dis = imod.mf6.StructuredDiscretization(top=200.0, bottom=bottom, idomain=idomain)
+    dis2 = dis.copy()
+    assert isinstance(dis2, imod.mf6.StructuredDiscretization)
+    assert dis2.dataset.equals(dis.dataset)
+
+
 def test_wrong_dtype(idomain_and_bottom):
     idomain, bottom = idomain_and_bottom
 
diff --git a/imod/tests/test_mf6/test_mf6_disv.py b/imod/tests/test_mf6/test_mf6_disv.py
@@ -79,6 +79,14 @@ def test_wrong_dtype(idomain_and_bottom):
         )
 
 
+def test_copy(idomain_and_bottom):
+    idomain, bottom = idomain_and_bottom
+    disv = imod.mf6.VerticesDiscretization(top=200.0, bottom=bottom, idomain=idomain)
+    disv2 = disv.copy()
+    assert isinstance(disv2, imod.mf6.VerticesDiscretization)
+    assert disv2.dataset.equals(disv.dataset)
+
+
 def test_zero_thickness_validation(idomain_and_bottom):
     idomain, bottom = idomain_and_bottom
     # Create a bottom array that has constant value of -1 across all layers, so
