MSS: fix several Flake8 warnings

BoboTiG · BoboTiG · commit 0e19632f5488 · 2018-12-26T22:22:23.000+01:00
- C408: Unnecessary dict call - rewrite as a literal
- I100: Import statements are in the wrong order
- I201: Missing newline before sections or imports
diff --git a/CHANGELOG b/CHANGELOG
@@ -2,8 +2,11 @@ History:
 
 <see Git checking messages for history>
 
-4.0.0   2018/12/23
+4.0.0   201x/xx/xx
       - MSS: renamed MSSBase to MSSMixin in base.py
+      - MSS: fix Flake8 C408: Unnecessary dict call - rewrite as a literal, in exceptions.py
+      - MSS: fix Flake8 I100: Import statements are in the wrong order
+      - MSS: fix Flake8 I201: Missing newline before sections or imports
 
 3.3.2   2018/11/20
       - new contributors: hugovk, Andreas Buhr
diff --git a/docs/source/examples/fps.py b/docs/source/examples/fps.py
@@ -12,7 +12,9 @@
 import time
 
 import cv2
+
 import mss
+
 import numpy
 
 
diff --git a/docs/source/examples/opencv_numpy.py b/docs/source/examples/opencv_numpy.py
@@ -9,7 +9,9 @@
 import time
 
 import cv2
+
 import mss
+
 import numpy
 
 
diff --git a/docs/source/examples/pil.py b/docs/source/examples/pil.py
@@ -6,9 +6,10 @@
 PIL example using frombytes().
 """
 
-import mss
 from PIL import Image
 
+import mss
+
 
 with mss.mss() as sct:
     # Get rid of the first, as it represents the "All in One" monitor:
diff --git a/docs/source/examples/pil_pixels.py b/docs/source/examples/pil_pixels.py
@@ -6,9 +6,10 @@
 PIL examples to play with pixels.
 """
 
-import mss
 from PIL import Image
 
+import mss
+
 
 with mss.mss() as sct:
     # Get a screenshot of the 1st monitor
diff --git a/mss/exception.py b/mss/exception.py
@@ -11,4 +11,4 @@ class ScreenShotError(Exception):
     def __init__(self, message, details=None):
         # type: (Dict[str, Any]) -> None
         super(Exception, self).__init__(message)
-        self.details = details or dict()
+        self.details = details or {}
diff --git a/tests/bench_bgra2rgb.py b/tests/bench_bgra2rgb.py
@@ -31,11 +31,12 @@
 
 import time
 
-import numpy
 from PIL import Image
 
 import mss
 
+import numpy
+
 
 def mss_rgb(im):
     return im.rgb
diff --git a/tests/bench_general.py b/tests/bench_general.py
@@ -25,6 +25,7 @@
 """
 
 from time import time
+
 import mss
 import mss.tools
 
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -5,10 +5,10 @@
 import glob
 import os
 
-import pytest
-
 import mss
 
+import pytest
+
 
 def pytest_addoption(parser):
     txt = 'Display to use (examples: ":0.1", ":0" [default])'
diff --git a/tests/test_bgra_to_rgb.py b/tests/test_bgra_to_rgb.py
@@ -1,9 +1,9 @@
 # coding: utf-8
 
-import pytest
-
 from mss.base import ScreenShot
 
+import pytest
+
 
 def test_bad_length():
     data = bytearray(b"789c626001000000ffff030000060005")
diff --git a/tests/test_get_pixels.py b/tests/test_get_pixels.py
@@ -1,10 +1,10 @@
 # coding: utf-8
 
-import pytest
-
 from mss.base import ScreenShot
 from mss.exception import ScreenShotError
 
+import pytest
+
 
 def test_grab_monitor(sct):
     for mon in sct.monitors:
diff --git a/tests/test_gnu_linux.py b/tests/test_gnu_linux.py
@@ -4,12 +4,12 @@
 import platform
 import sys
 
-import pytest
-
 import mss
 from mss.base import MSSMixin
 from mss.exception import ScreenShotError
 
+import pytest
+
 
 if platform.system().lower() != "linux":
     pytestmark = pytest.mark.skip
diff --git a/tests/test_implementation.py b/tests/test_implementation.py
@@ -5,14 +5,14 @@
 import platform
 import sys
 
-import pytest
-
 import mss
 import mss.tools
 from mss.base import MSSMixin
 from mss.exception import ScreenShotError
 from mss.screenshot import ScreenShot
 
+import pytest
+
 
 PY3 = sys.version[0] > "2"
 
diff --git a/tests/test_macos.py b/tests/test_macos.py
@@ -3,11 +3,12 @@
 import ctypes.util
 import platform
 
-import pytest
-
 import mss
 from mss.exception import ScreenShotError
 
+import pytest
+
+
 if platform.system().lower() != "darwin":
     pytestmark = pytest.mark.skip
 
diff --git a/tests/test_tools.py b/tests/test_tools.py
@@ -4,10 +4,10 @@
 import os.path
 import zlib
 
-import pytest
-
 from mss.tools import to_png
 
+import pytest
+
 
 WIDTH = 10
 HEIGHT = 10
diff --git a/tests/test_windows.py b/tests/test_windows.py
@@ -3,11 +3,11 @@
 import ctypes.util
 import platform
 
-import pytest
-
 import mss
 from mss.exception import ScreenShotError
 
+import pytest
+
 
 if platform.system().lower() != "windows":
     pytestmark = pytest.mark.skip
