Remove unnecessary delayed processing of value

AlexanderWells-diamond · AlexanderWells-diamond · commit 5cdc614682d3 · 2024-04-08T13:56:19.000+01:00
Previously we did this as we wanted to spot the case where no value
was provided, either during record creation or by a set() call at some
later time, so that we could mark the record as being in an invalid
state.

Now that we store the severity and status alongside the value, we don't
need to handle this special case.
diff --git a/softioc/device.py b/softioc/device.py
@@ -180,7 +180,7 @@ def __init__(self, name, **kargs):
             initial_severity = alarm.NO_ALARM
             initial_status = alarm.NO_ALARM
         else:
-            value = None
+            value = self._default_value()
             # To maintain backwards compatibility, if there is no initial value
             # we mark the record as invalid
             initial_severity = alarm.INVALID_ALARM
@@ -198,11 +198,6 @@ def init_record(self, record):
         '''Special record initialisation for out records only: implements
         special record initialisation if an initial value has been specified,
         allowing out records to have a sensible initial value.'''
-        if self._value[0] is None:
-            # Cannot set in __init__ (like we do for In records), as we want
-            # the record alarm status to be set if no value was provided
-            value = self._default_value()
-            self._value = (value, self._value[1], self._value[2])
 
         self._write_value(record, self._value[0])
         if 'MLST' in self._fields_:
