minor #7589 Fix CrudTestSelectors::getActionSelector() not matching grouped actions (lacatoire)

javiereguiluz · javiereguiluz · commit fe2f4b2d51be · 2026-05-09T19:51:52.000+02:00
This PR was submitted for the 5.x branch but it was merged into the 4.x branch instead. Discussion ---------- Fix CrudTestSelectors::getActionSelector() not matching grouped actions ``CrudTestSelectors::getActionSelector()`` looked for the ``.action-<name>`` CSS class. That class is set only on top-level actions by ``ActionFactory::transformActions()``; actions nested inside an ``ActionGroup`` go through ``processActionGroup()`` and never receive it, so test helpers like ``assertIndexEntityActionExists()`` silently failed on grouped actions. Switch the selector to ``[data-action-name="<name>"]``, which ``ActionFactory::processAction()`` sets unconditionally on every action (top-level or nested). A single attribute selector also avoids the comma-OR composition pitfall in ``getGlobalActionSelector()`` / ``getIndexEntityActionSelector()``, which otherwise let the right-hand branch escape the scope. Fixes #7518 Commits ------- 0977a23 Make getActionSelector() match grouped actions via data-action-name
diff --git a/src/Test/Trait/CrudTestSelectors.php b/src/Test/Trait/CrudTestSelectors.php
@@ -16,7 +16,12 @@ protected function getIndexEntityRowSelector(string|int $entityId): string
 
     protected function getActionSelector(string $action): string
     {
-        return sprintf('.action-%s', $action);
+        // every action (top-level or nested in an ActionGroup) carries a
+        // `data-action-name` attribute set by ActionFactory::processAction(),
+        // so it's the only reliable selector for the test helpers. The legacy
+        // `.action-<name>` CSS class is only set on top-level actions and is
+        // therefore not usable when the action lives inside an ActionGroup.
+        return sprintf('[data-action-name="%s"]', $action);
     }
 
     protected function getGlobalActionSelector(string $action): string

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,12 @@ protected function getIndexEntityRowSelector(string\|int $entityId): string`
`16`	`16`
`17`	`17`	`protected function getActionSelector(string $action): string`
`18`	`18`	`{`
`19`		`- return sprintf('.action-%s', $action);`
	`19`	`+ // every action (top-level or nested in an ActionGroup) carries a`
	`20`	+ // `data-action-name` attribute set by ActionFactory::processAction(),
	`21`	`+ // so it's the only reliable selector for the test helpers. The legacy`
	`22`	+ // `.action-<name>` CSS class is only set on top-level actions and is
	`23`	`+ // therefore not usable when the action lives inside an ActionGroup.`
	`24`	`+ return sprintf('[data-action-name="%s"]', $action);`
`20`	`25`	`}`
`21`	`26`
`22`	`27`	`protected function getGlobalActionSelector(string $action): string`