Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make v5 allow PHP 8 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
svnldwg opened this issue Mar 3, 2021 · 3 comments
Closed

Make v5 allow PHP 8 #17

svnldwg opened this issue Mar 3, 2021 · 3 comments

Comments

@svnldwg
Copy link

svnldwg commented Mar 3, 2021

Hey, I recently stumbled across this and project and I am using it and loving it, thanks for the great work!

I am using it in conjunction with PHP 8 and thecodingmachine/graphqlite.

graphqlite has a requirement for webonyx/graphql-php ^v0.13.4 (https://github.com/thecodingmachine/graphqlite/blob/master/composer.json#L14).

graphql-upload v6 requires webonyx/graphql-php ^14.

Therefore currently I can only use graphql-upload v5 together with graphqlite. But graqhl-upload v5 does not support PHP 8, so it is impossible to use graphql-php in my setup. That is why I created a fork and tagged a 5.0.1 which allows PHP 8.

This is all I had to do: svnldwg-forks@57b5d83

It works, but I would love to get rid of my fork and just use the original project. Could you allow PHP 8 for v5?
@PowerKiKi
Copy link
Member

I'm surprised to learn that you use both libraries together. I'm not familiar with thecodingmachine/graphqlite, but was under the impression that it would be more of a replacement to ecodev/graphql-upload, rather than a complement.

But anyway, unfortunately we don't support past versions. And even though this particular change seems small, I am not willing to introduce a precedent by accepting this change.

Instead I would suggest to push for an update of thecodingmachine/graphqlite. It seems they are willing to do it and would accept help for it. There is also an opened PR for it: thecodingmachine/graphqlite#327

@svnldwg
Copy link
Author

svnldwg commented Mar 4, 2021

Thanks for your reply, I understand.

Yes, thecodingmachine/graphqlite relies on your package for file uploads. It is documented here: https://graphqlite.thecodingmachine.io/docs/file-uploads

@PowerKiKi
Copy link
Member

Oh my bad, I thought we were talking about ecodev/graphql-doctrine 🙄 , which is a replacement to thecodingmachine/graphqlite. But ecodev/graphql-upload totally make sense to be used with thecodingmachine/graphqlite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PowerKiKi @svnldwg