feat: rewrite frontend-design skill with layered architecture and visual verification#343
Merged
Conversation
Spec for rewriting the frontend-design skill with layered architecture (context detection, pre-build planning, design guidance, context modules, verification) and surgical ce:work-beta integration.
Replace the 43-line aesthetic manifesto with a structured, cross-agent compatible skill covering: - Layer 0: Context detection (existing design system, partial, greenfield) - Layer 1: Pre-build planning (visual thesis, content plan, interaction plan) - Layer 2: Design guidance (typography, color, composition, motion, a11y, imagery) - Context modules (landing pages, apps, components/features) - Two-tier anti-patterns (overridable defaults vs quality floor) - Visual verification via browser screenshot with tool cascade - Authority hierarchy: existing system > user instructions > skill defaults
Add conditional section in Phase 2 that loads the frontend-design skill for UI tasks without Figma designs. Also fixes duplicate item numbering (two items were both numbered "6.").
frontend-design skill with layered architecture and visual verification
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef0703be4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Make Phase 4 screenshot conditional on skill producing one (mental review fallback still requires Phase 4 capture) - Use fully qualified agent name for design-iterator per AGENTS.md
Merged
Collaborator
Author
|
@mvanhorn fyi on this PR. I've integrated with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the
frontend-designskill from a 43-line aesthetic manifesto into a structured, layered, cross-agent compatible skill that detects existing design systems, provides context-specific guidance, and verifies its own output via browser screenshots. Also adds a surgical trigger ince-work-betato load the skill for UI tasks without Figma designs.Problem
The current
frontend-designskill provides vague creative encouragement ("be bold", "choose a BOLD aesthetic direction") but lacks:ce:work-betahas no way to invoke it (skill is effectively orphaned)Approach
We analyzed two external references and synthesized the best ideas from each:
Anthropic's official frontend-design skill -- our current skill was originally based on this. Nearly identical to ours, same gaps. Credit to Anthropic for the foundational anti-AI-slop identity and creative energy that we carry forward.
OpenAI's "Designing Delightful Frontends with GPT-5.4" -- dramatically more comprehensive with composition rules, context modules, card philosophy, copy guidelines, motion specifics, and litmus checks. Credit to OpenAI for demonstrating the level of structure needed to produce genuinely good frontend output from coding agents.
Where we go beyond both
New skill structure (Layer 0 through Visual Verification)
ce-work-beta integration
Added a new Phase 2 item that loads the
frontend-designskill for UI tasks without Figma designs. Also fixed pre-existing duplicate item numbering (two items were both "6.").Files changed
plugins/compound-engineering/skills/frontend-design/SKILL.mdplugins/compound-engineering/skills/ce-work-beta/SKILL.mddocs/brainstorms/2026-03-22-frontend-design-skill-improvement.mddocs/plans/2026-03-22-001-feat-frontend-design-skill-rewrite-beta-plan.mdTest plan
bun test-- 364 pass, 0 failbun run release:validate-- metadata in sync (29 agents, 42 skills, 1 MCP server)frontend-designskill on a greenfield landing page taskfrontend-designskill on a component addition in an existing Next.js app (should detect design system and use Module C)ce:work-betaon a plan with UI tasks and no Figma designs (should auto-load the skill)