Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: rewrite frontend-design skill with layered architecture and visual verification#343

Merged
tmchow merged 5 commits into
mainfrom
feat/improve-frontend-skill
Mar 23, 2026
Merged

feat: rewrite frontend-design skill with layered architecture and visual verification#343
tmchow merged 5 commits into
mainfrom
feat/improve-frontend-skill

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Mar 23, 2026

Summary

Rewrites the frontend-design skill from a 43-line aesthetic manifesto into a structured, layered, cross-agent compatible skill that detects existing design systems, provides context-specific guidance, and verifies its own output via browser screenshots. Also adds a surgical trigger in ce-work-beta to load the skill for UI tasks without Figma designs.

Problem

The current frontend-design skill provides vague creative encouragement ("be bold", "choose a BOLD aesthetic direction") but lacks:

  • Context detection -- no mechanism to detect existing design systems, so it fights the codebase
  • Practical structure -- no concrete constraints, just aesthetic aspiration
  • Context-specific guidance -- landing pages, dashboards, and components in existing apps all get the same "be bold" treatment
  • Accessibility -- zero mention of contrast, focus states, or semantic HTML
  • Verification -- no step to actually look at what was built
  • Beta workflow integration -- ce:work-beta has no way to invoke it (skill is effectively orphaned)

Approach

We analyzed two external references and synthesized the best ideas from each:

  1. Anthropic's official frontend-design skill -- our current skill was originally based on this. Nearly identical to ours, same gaps. Credit to Anthropic for the foundational anti-AI-slop identity and creative energy that we carry forward.

  2. OpenAI's "Designing Delightful Frontends with GPT-5.4" -- dramatically more comprehensive with composition rules, context modules, card philosophy, copy guidelines, motion specifics, and litmus checks. Credit to OpenAI for demonstrating the level of structure needed to produce genuinely good frontend output from coding agents.

Where we go beyond both

Gap Anthropic OpenAI Ours
Existing codebase detection None One exception line buried in rules Layer 0: First step, concrete checklist, mode classification
Authority hierarchy None Rules as absolutes Existing system > user instructions > skill defaults
Context modules None Landing pages + apps Landing pages + apps + components/features (the common case)
Accessibility None None Semantic HTML, WCAG AA contrast, focus states
Animation library Assumes CSS/Motion Assumes Framer Motion Detects existing, framework-conditional defaults
Verification None Conceptual litmus checks only Browser screenshot + self-assessment with tool cascade
Cross-agent compat Claude-only Codex-only Claude Code, Codex, Gemini CLI with fallbacks
User choice No escape hatches Rules as absolutes Two-tier: overridable defaults vs quality floor

New skill structure (Layer 0 through Visual Verification)

Frontmatter (optimized description for discovery)
Preamble (authority hierarchy, workflow preview)
Layer 0: Context Detection
  - Concrete signal checklist (design tokens, component libs, CSS frameworks, etc.)
  - Mode classification: existing (4+) / partial (1-3) / greenfield (0) / ambiguous (ask)
  - Cross-platform question pattern with fallback
Layer 1: Pre-Build Planning
  - Visual thesis, content plan, interaction plan (3 short statements)
Layer 2: Design Guidance Core
  - Typography, Color, Composition, Motion, Accessibility, Imagery
  - All yield to existing systems
Context Modules (select one)
  - A: Landing Pages (greenfield)
  - B: Apps & Dashboards (greenfield)
  - C: Components & Features (default in existing apps)
Hard Rules & Anti-Patterns (two tiers)
Litmus Checks (context-sensitive)
Visual Verification (tool cascade: existing > MCP > agent-browser > mental review)
Creative Energy (carried forward from original skill)

ce-work-beta integration

Added a new Phase 2 item that loads the frontend-design skill for UI tasks without Figma designs. Also fixed pre-existing duplicate item numbering (two items were both "6.").

Files changed

File Change
plugins/compound-engineering/skills/frontend-design/SKILL.md Full rewrite (43 -> 248 lines)
plugins/compound-engineering/skills/ce-work-beta/SKILL.md +9 lines in Phase 2 (new item 7 + numbering fix)
docs/brainstorms/2026-03-22-frontend-design-skill-improvement.md Design spec
docs/plans/2026-03-22-001-feat-frontend-design-skill-rewrite-beta-plan.md Implementation plan

Test plan

  • bun test -- 364 pass, 0 fail
  • bun run release:validate -- metadata in sync (29 agents, 42 skills, 1 MCP server)
  • AGENTS.md skill compliance checklist verified (cross-platform question patterns, semantic skill references, no hardcoded tool names, imperative voice)
  • Manual test: invoke frontend-design skill on a greenfield landing page task
  • Manual test: invoke frontend-design skill on a component addition in an existing Next.js app (should detect design system and use Module C)
  • Manual test: run ce:work-beta on a plan with UI tasks and no Figma designs (should auto-load the skill)

tmchow added 4 commits March 22, 2026 17:35
Spec for rewriting the frontend-design skill with layered architecture
(context detection, pre-build planning, design guidance, context modules,
verification) and surgical ce:work-beta integration.
Replace the 43-line aesthetic manifesto with a structured, cross-agent
compatible skill covering:
- Layer 0: Context detection (existing design system, partial, greenfield)
- Layer 1: Pre-build planning (visual thesis, content plan, interaction plan)
- Layer 2: Design guidance (typography, color, composition, motion, a11y, imagery)
- Context modules (landing pages, apps, components/features)
- Two-tier anti-patterns (overridable defaults vs quality floor)
- Visual verification via browser screenshot with tool cascade
- Authority hierarchy: existing system > user instructions > skill defaults
Add conditional section in Phase 2 that loads the frontend-design skill
for UI tasks without Figma designs. Also fixes duplicate item numbering
(two items were both numbered "6.").
@tmchow tmchow changed the title feat(ce): rewrite frontend-design skill with layered architecture and visual verification feat: rewrite frontend-design skill with layered architecture and visual verification Mar 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef0703be4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/compound-engineering/skills/ce-work-beta/SKILL.md
Comment thread plugins/compound-engineering/skills/ce-work-beta/SKILL.md Outdated
Comment thread plugins/compound-engineering/skills/frontend-design/SKILL.md Outdated
- Make Phase 4 screenshot conditional on skill producing one (mental
  review fallback still requires Phase 4 capture)
- Use fully qualified agent name for design-iterator per AGENTS.md
@tmchow tmchow merged commit 423e692 into main Mar 23, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 23, 2026
@tmchow
Copy link
Copy Markdown
Collaborator Author

tmchow commented Mar 23, 2026

@mvanhorn fyi on this PR. I've integrated with ce:work-beta to try to improve FE designs in a variety of ways. It was natural to connect it with the work-beta skill vs the stable skill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant