fix: guard CONTEXTUAL_RISK_FLAGS lookup against prototype pollution#377
Merged
Conversation
Bracket-notation lookup on a plain object returned inherited prototype methods (e.g. constructor, toString) which don't have .has(), causing a TypeError at runtime. Guard with Object.hasOwn() so only own properties are returned. Extract normalization logic into scripts/normalize.mjs for testability and add regression tests covering prototype property names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract-commands.mjswhere bracket-notation lookup onCONTEXTUAL_RISK_FLAGScould return inherited prototype methods (e.g.constructor,toString) that don't have.has(), crashing the script on certain command tokens.Object.hasOwn()so only own properties (-f,-v) are returned.isRiskFlagandnormalizeinto a separatenormalize.mjsmodule for testability.Test plan
bun test— all 386 tests passextract-commands.mjsend-to-end — runs without errorsconstructor,toString,valueOf,hasOwnProperty,__proto__) no longer throw