feat(git-commit-push-pr): add conditional visual aids to PR descriptions#444
Merged
Conversation
Add a Visual communication subsection to Step 6 with content-pattern-based triggers for including mermaid diagrams, ASCII art, and comparison tables in PR descriptions. Follows the same conditional approach as ce:brainstorm (#437) and ce:plan (#440), calibrated for the PR scanning context with a higher trigger bar and smaller diagrams (5-10 nodes typical).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a966a04147
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ges only Remove "3-5 sentences" from the blanket skip criterion so that small-but-structurally-complex changes can still receive visual aids when content patterns warrant it. Resolves contradiction with the content-pattern-based inclusion principle. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
#### Visual communicationsubsection to git-commit-push-pr's Step 6, completing the visual aids trilogy across the plugin's document-generating skills. Complex PRs with architectural changes, workflow modifications, or multi-component interactions can now include mermaid diagrams, ASCII art, or comparison tables in their descriptions -- when the content warrants it.This follows the same content-pattern-based conditional approach established in ce:brainstorm (#437) and ce:plan (#440), adapted for the PR description surface where reviewers scan quickly rather than study deeply.
Key decisions
Also included
docs/plans/2026-03-29-003-feat-pr-description-visual-aids-plan.mddocs/solutions/best-practices/conditional-visual-aids-in-generated-documents-2026-03-29.md-- comprehensive reference covering the conditional visual aid pattern across all three skills, including decision framework for format selection, surface-specific calibration, cross-device layout optimization, and prevention checklist.Test plan
bun test)docs/solutions/skill-design/git-workflow-skills-need-explicit-state-machines-2026-03-27.md)🤖 Generated with Claude Opus 4.6 (1M context, extended thinking) via Claude Code