fix(review): harden ce-review base resolution#452
Merged
Conversation
Clarify that previous-comments only runs for PR reviews, make persona model guidance tolerant of platforms without explicit model overrides, and harden resolve-base.sh for shallow and forked checkouts. Add an integration test suite that executes resolve-base.sh against local git repos, including detached shallow checkout scenarios that approximate GitHub Actions.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1addfe48f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Drop the detached-shallow test's assumption that a local main branch exists after cloning. Git's branch creation differs across platforms, but the test only needs origin/HEAD to exist to exercise the intended code path.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This tightens ce-review branch and PR scope handling in two places that were easy to get wrong in practice.
First, it makes the
previous-commentsreviewer explicitly PR-only and aligns the review docs so standalone branch reviews do not dispatch a reviewer that requires PR context. Second, it hardensresolve-base.shfor forked and shallow checkouts by fetching explicit remote-tracking refs and retrying merge-base resolution after unshallowing when the checkout history is incomplete.Testing
bun test tests/resolve-base-script.test.tsbun testWhy this matters
The new integration test suite executes the real
resolve-base.shscript against temp git repos, including detached shallow checkout scenarios that approximate GitHub Actions. That caught real base-resolution failures and now protects the forked and CI review path from regressing.