fix(cli): resolve repo-wide tsc --noEmit type errors#512
Merged
Conversation
- Add @types/js-yaml for missing declaration file - Type-annotate options objects in convert/install commands to narrow agentMode from string to the expected union literal - Widen permission record value type to include nested pattern records, removing unsafe type assertions in claude-to-opencode converter - Cast target handler write/convert to TargetHandler (erased generic) instead of TargetHandler<SpecificBundle> which didn't fix contravariance Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/js-yamldev dependencyoptionsobjects inconvertandinstallcommands soagentModenarrows fromstringto"primary" | "subagent"permissionrecord value type inclaude-to-opencode.tsto accept nested pattern records, removing four unsafeascastsas TargetHandler<SpecificBundle>["write"]toas TargetHandler["write"]across all targets — the previous casts were no-ops that didn't resolve the contravariance mismatch against the erasedRecord<string, TargetHandler>typeTest plan
bunx tsc --noEmitpasses (0 errors, was 21)bun testpasses (586/586)🤖 Generated with Claude Code