Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ce-code-review): restate model override at dispatch point#681

Merged
tmchow merged 1 commit into
mainfrom
fix/code-review-model-override-at-dispatch
Apr 28, 2026
Merged

fix(ce-code-review): restate model override at dispatch point#681
tmchow merged 1 commit into
mainfrom
fix/code-review-model-override-at-dispatch

Conversation

@tmchow
Copy link
Copy Markdown
Collaborator

@tmchow tmchow commented Apr 24, 2026

Reviewers were dispatching on the session model (Opus 4.7) instead of the mid-tier Sonnet the skill directs, burning through usage on persona reviewers that don't need frontier reasoning. The root cause was placement: the model: "sonnet" imperative lived only in a prose "Model tiering" rationale subsection, separated from the "Spawning" subsection that governs actual dispatch. Under 12-agent parallel dispatch, that upstream paragraph fell out of attention.

The fix restates the imperative inside Spawning alongside the existing mode paragraph. The 3 session-model exception reviewers (ce-correctness-reviewer, ce-security-reviewer, ce-adversarial-reviewer) are named inline, and the directive covers all cross-platform dispatch primitives (Agent in Claude Code, spawn_agent in Codex, subagent in Pi). The existing "omit if unknown" fallback is preserved for platforms without a model-override parameter. A contract test locks the imperative inside the Spawning subsection so it cannot drift back out to rationale.

Fixes #679


Compound Engineering
Claude Code

Copy link
Copy Markdown

@npwalker npwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

The mid-tier model directive lived only in a prose "Model tiering"
rationale subsection, separated from the "Spawning" subsection that
governs actual dispatch. Under multi-agent parallel dispatch (12
reviewers), the upstream rationale paragraph reliably fell out of
attention and reviewers spawned on the session model (often Opus)
instead of the platform's mid-tier model — silently multiplying the
cost of a review.

Restate the imperative at the Spawning point-of-action alongside the
existing `mode` paragraph, naming the three session-model exception
reviewers (ce-correctness-reviewer, ce-security-reviewer,
ce-adversarial-reviewer) inline so the agent does not have to recall
them from upstream prose. Cover all three cross-platform dispatch
primitives (Agent / spawn_agent / subagent) and preserve the existing
"omit if unknown" fallback. Add a contract test that extracts the
Spawning subsection and asserts the imperative, platform primitives,
and exception reviewers appear within it, so the directive cannot
drift back out to rationale.

Fixes #679
@tmchow tmchow force-pushed the fix/code-review-model-override-at-dispatch branch from 174a4ff to 90df48c Compare April 28, 2026 08:11
@tmchow tmchow merged commit 9751d1a into main Apr 28, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
michaelvolz pushed a commit to michaelvolz/compound-engineering-plugin-windows-version that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reviewers spawn as Opus 4.7 instead of Sonnet as expected

2 participants