fix(ce-code-review): restate model override at dispatch point#681
Merged
Conversation
The mid-tier model directive lived only in a prose "Model tiering" rationale subsection, separated from the "Spawning" subsection that governs actual dispatch. Under multi-agent parallel dispatch (12 reviewers), the upstream rationale paragraph reliably fell out of attention and reviewers spawned on the session model (often Opus) instead of the platform's mid-tier model — silently multiplying the cost of a review. Restate the imperative at the Spawning point-of-action alongside the existing `mode` paragraph, naming the three session-model exception reviewers (ce-correctness-reviewer, ce-security-reviewer, ce-adversarial-reviewer) inline so the agent does not have to recall them from upstream prose. Cover all three cross-platform dispatch primitives (Agent / spawn_agent / subagent) and preserve the existing "omit if unknown" fallback. Add a contract test that extracts the Spawning subsection and asserts the imperative, platform primitives, and exception reviewers appear within it, so the directive cannot drift back out to rationale. Fixes #679
174a4ff to
90df48c
Compare
Merged
michaelvolz
pushed a commit
to michaelvolz/compound-engineering-plugin-windows-version
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers were dispatching on the session model (Opus 4.7) instead of the mid-tier Sonnet the skill directs, burning through usage on persona reviewers that don't need frontier reasoning. The root cause was placement: the
model: "sonnet"imperative lived only in a prose "Model tiering" rationale subsection, separated from the "Spawning" subsection that governs actual dispatch. Under 12-agent parallel dispatch, that upstream paragraph fell out of attention.The fix restates the imperative inside Spawning alongside the existing
modeparagraph. The 3 session-model exception reviewers (ce-correctness-reviewer,ce-security-reviewer,ce-adversarial-reviewer) are named inline, and the directive covers all cross-platform dispatch primitives (Agentin Claude Code,spawn_agentin Codex,subagentin Pi). The existing "omit if unknown" fallback is preserved for platforms without a model-override parameter. A contract test locks the imperative inside the Spawning subsection so it cannot drift back out to rationale.Fixes #679