Improve selection methods naming

ipedro · ipedro · commit de3fd5ce47c5 · 2021-04-21T08:29:21.000+02:00
diff --git a/Sources/UIKeyCommandTableView/UIKeyCommandTableView.swift b/Sources/UIKeyCommandTableView/UIKeyCommandTableView.swift
@@ -116,10 +116,10 @@ public class UIKeyCommandTableView: UITableView {
         switch validate(indexPath) {
             
         case .success:
-            handleValidSelection(with: indexPath)
+            handleSelectionSuccess(at: indexPath)
             
         case let .failure(reason):
-            handleInvalidSelection(with: indexPath, reason: reason)
+            handleSelectionFailure(at: indexPath, reason: reason)
         }
     }
     
@@ -139,7 +139,7 @@ private extension UIKeyCommandTableView {
         }
     }
     
-    func handleValidSelection(with indexPath: IndexPath) {
+    func handleSelectionSuccess(at indexPath: IndexPath) {
         var selectedIndexPath: IndexPath? {
             guard let delegate = delegate else {
                 return indexPath
@@ -164,7 +164,7 @@ private extension UIKeyCommandTableView {
         }
     }
     
-    func handleInvalidSelection(with indexPath: IndexPath, reason: IndexPath.InvalidReason) {
+    func handleSelectionFailure(at indexPath: IndexPath, reason: IndexPath.InvalidReason) {
         switch reason {
         case .sectionBelowBounds:
             switch keyCommandsDelegate?.tableViewKeyCommandSelectionBelowBounds(self) {

Original file line number	Diff line number	Diff line change
`@@ -116,10 +116,10 @@ public class UIKeyCommandTableView: UITableView {`
`116`	`116`	`switch validate(indexPath) {`
`117`	`117`
`118`	`118`	`case .success:`
`119`		`- handleValidSelection(with: indexPath)`
	`119`	`+ handleSelectionSuccess(at: indexPath)`
`120`	`120`
`121`	`121`	`case let .failure(reason):`
`122`		`- handleInvalidSelection(with: indexPath, reason: reason)`
	`122`	`+ handleSelectionFailure(at: indexPath, reason: reason)`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`
`@@ -139,7 +139,7 @@ private extension UIKeyCommandTableView {`
`139`	`139`	`}`
`140`	`140`	`}`
`141`	`141`
`142`		`- func handleValidSelection(with indexPath: IndexPath) {`
	`142`	`+ func handleSelectionSuccess(at indexPath: IndexPath) {`
`143`	`143`	`var selectedIndexPath: IndexPath? {`
`144`	`144`	`guard let delegate = delegate else {`
`145`	`145`	`return indexPath`
`@@ -164,7 +164,7 @@ private extension UIKeyCommandTableView {`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`
`167`		`- func handleInvalidSelection(with indexPath: IndexPath, reason: IndexPath.InvalidReason) {`
	`167`	`+ func handleSelectionFailure(at indexPath: IndexPath, reason: IndexPath.InvalidReason) {`
`168`	`168`	`switch reason {`
`169`	`169`	`case .sectionBelowBounds:`
`170`	`170`	`switch keyCommandsDelegate?.tableViewKeyCommandSelectionBelowBounds(self) {`