fix(config): Prevent printf injection in replication.conf

Artyom Ivanov · AlexPeshkoff · commit 697f6012f45b · 2025-05-07T11:23:02.000+03:00
diff --git a/src/jrd/replication/Config.cpp b/src/jrd/replication/Config.cpp
@@ -81,9 +81,7 @@ namespace
 
 	void configError(const string& type, const string& key, const string& value)
 	{
-		string msg;
-		msg.printf("%s specifies %s: %s", key.c_str(), type.c_str(), value.c_str());
-		raiseError(msg.c_str());
+		raiseError("%s specifies %s: %s", key.c_str(), type.c_str(), value.c_str());
 	}
 
 	void checkAccess(const PathName& path, const string& key)

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ namespace`
`81`	`81`
`82`	`82`	`void configError(const string& type, const string& key, const string& value)`
`83`	`83`	`{`
`84`		`- string msg;`
`85`		`- msg.printf("%s specifies %s: %s", key.c_str(), type.c_str(), value.c_str());`
`86`		`- raiseError(msg.c_str());`
	`84`	`+ raiseError("%s specifies %s: %s", key.c_str(), type.c_str(), value.c_str());`
`87`	`85`	`}`
`88`	`86`
`89`	`87`	`void checkAccess(const PathName& path, const string& key)`