Allow config changing plugins to operate while daemon is running #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self._has_lock | ||
|
|
||
| @property | ||
| def should_reload(self): |
Member
There was a problem hiding this comment.
Avoid word reload as it is mistaken for actual file reload that is coming hopefully some day :)
Member
Author
There was a problem hiding this comment.
but it is reloaded, from memory.
also, we have reload from file now, not sure what you mean,
Other than this, are you cool with this? Because @gazpachoking didn't like the whole triggering reload in the core thing. Unfortunately this is the only way to load cli-config now when daemon is running.
Member
|
Is this even relevant anymore as daemon reloads config automatically (in next branch) |
Member
Author
|
Yes, daemon reload on config hash change. The change in pr triggers the plugin usage while in daemon mode,two related but not the same |
paranoidi
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
cli_configcan't work when daemon is running since config isn't reloaded and manager doesn't add updated options to itself when firing event. This kinda fixes that in a hacky way. need some ideas how to do this better.This should affect affect any config editing plugin, like
secretsas well.Addressed issues: