Fix non-check of bytes sent over Unix socket #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a very strange issue with rTorrent; payloads/torrent encoded payloads bigger than 16256 bytes were failing. I put some logging around this `sock.send` line. Here's a working example: ```2017-05-11 20:27 VERBOSE rtorrent task Calling load.raw() 2017-05-11 20:27 INFO rtorrent task Sending body of len: 11344 2017-05-11 20:27 INFO rtorrent task Actually sent len: 11344 2017-05-11 20:27 INFO rtorrent task Sending body of len: 1026 2017-05-11 20:27 INFO rtorrent task Actually sent len: 1026 2017-05-11 20:27 INFO rtorrent task some.torrent.title added to rtorrent ``` And this is a broken example: ```2017-05-11 13:20 INFO rtorrent task Sending body of len: 5734 2017-05-11 13:20 INFO rtorrent task Actually sent len: 5734 2017-05-11 13:20 INFO rtorrent task Sending body of len: 18164 2017-05-11 13:20 INFO rtorrent task Actually sent len: 16256 2017-05-11 13:20 ERROR rtorrent task timed out ``` ... and is then followed by an exception. Using `socket.sendall` may not be the ideal solution, but it seems good enough for me.
Fix non-check of bytes sent over Unix socket
gazpachoking
approved these changes
May 23, 2017
Member
gazpachoking
left a comment
There was a problem hiding this comment.
I don't have any special knowledge on this, but it seems pretty reasonable after reading the socket docs.
https://docs.python.org/2/library/socket.html#socket.socket.send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a very strange issue with rTorrent; payloads/torrent encoded payloads bigger than 16256 bytes were failing. I put some logging around this
sock.sendline. Here's a working example:And this is a broken example:
... and is then followed by an exception.
Using
socket.sendallmay not be the ideal solution, but it seems good enough for me.