Corrected analysisOptions.ts bug (microsoft#5598)

Kartik Raj · web-flow · commit df3ed6df19bd · 2019-05-10T11:55:44.000-07:00
* Changes to analysisOptions.ts

* News entry
diff --git a/news/2 Fixes/5579.md b/news/2 Fixes/5579.md
@@ -0,0 +1 @@
+Corrected analysisOptions.ts bug
diff --git a/src/client/activation/languageServer/analysisOptions.ts b/src/client/activation/languageServer/analysisOptions.ts
@@ -225,7 +225,7 @@ export class LanguageServerAnalysisOptions implements ILanguageServerAnalysisOpt
 
     protected async notifyifEnvPythonPathChanged(): Promise<void> {
         const vars = await this.envVarsProvider.getEnvironmentVariables();
-        const envPythonPath = vars.PYTHONPATH;
+        const envPythonPath = vars.PYTHONPATH || '';
 
         if (this.envPythonPath !== envPythonPath) {
             this.didChange.fire();
diff --git a/src/client/common/installer/pipEnvInstaller.ts b/src/client/common/installer/pipEnvInstaller.ts
@@ -34,7 +34,7 @@ export class PipEnvInstaller extends ModuleInstaller implements IModuleInstaller
         const args = ['install', moduleName, '--dev'];
         if (moduleName === 'black') {
             args.push('--pre');
-        };
+        }
         return {
             args: args,
             execPath: pipenvName
