Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Group signals only once per Block #15

@achilleas-k

Description

@achilleas-k

The _group_signals() method is called once per Group/Segment

dataarrays = self._group_signals(dataarrays)

and then a final time in each Block to find "groupless" signals:

blockdas = self._group_signals(nix_block.data_arrays)

It's not generally a slow process. There's a sorting going on in the method which is going to be removed soon (see NeuralEnsemble#545) and ignoring that, it's an O(N) function. Now, N is the number of signals first in a Group/Segment, and then for the whole Block, so all in all the entire reading process reads through the DataArrays twice. Since we're reading all the DataArrays in a Block anyway, we might as well collect them before descending into a Group and use a per-block collection/grouping of signals.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions