Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 89aad43

Browse files
committed
h5: drag&drop code cleanup
* went through new code for DD and made sure we have a type for everything * cleanup to match lib style (public vs private) * made all routines return 'this' for chainable calls. Abstract DDBaseImplement still return :void otherwise had to do `return this as unknown as DDBaseImplement` for all sub-classes which is annoying. * created DDUIData to hold what we need for callback data. Commented out part we don't use today...
1 parent ed058d9 commit 89aad43

13 files changed

+405
-314
lines changed

src/dragdrop/dd-base-impl.ts

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,32 @@
77
*/
88
export type EventCallback = (event: Event) => boolean|void;
99
export abstract class DDBaseImplement {
10-
disabled = false;
10+
protected disabled = false;
1111
private eventRegister: {
1212
[eventName: string]: EventCallback;
1313
} = {};
14-
on(event: string, callback: EventCallback): void {
14+
15+
public on(event: string, callback: EventCallback): void {
1516
this.eventRegister[event] = callback;
1617
}
17-
off(event: string) {
18+
19+
public off(event: string): void {
1820
delete this.eventRegister[event];
1921
}
20-
enable(): void {
22+
23+
public enable(): void {
2124
this.disabled = false;
2225
}
23-
disable(): void {
26+
27+
public disable(): void {
2428
this.disabled = true;
2529
}
26-
destroy() {
27-
this.eventRegister = undefined;
30+
31+
public destroy(): void {
32+
delete this.eventRegister;
2833
}
29-
triggerEvent(eventName: string, event: Event): boolean|void {
34+
35+
public triggerEvent(eventName: string, event: Event): boolean|void {
3036
if (this.disabled) { return; }
3137
if (!this.eventRegister) {return; } // used when destroy before triggerEvent fire
3238
if (this.eventRegister[eventName]) {
@@ -38,5 +44,5 @@ export abstract class DDBaseImplement {
3844
export interface HTMLElementExtendOpt<T> {
3945
el: HTMLElement;
4046
option: T;
41-
updateOption(T): void;
47+
updateOption(T): DDBaseImplement;
4248
}

0 commit comments

Comments
 (0)