Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repository topology constraints related questions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nulltoken opened this issue Nov 20, 2013 · 2 comments
Closed

Repository topology constraints related questions #37

nulltoken opened this issue Nov 20, 2013 · 2 comments

Comments

@nulltoken
Copy link
Contributor

According to http://nvie.com/posts/a-successful-git-branching-model/

A repository is expected to contain at least two branches: master and develop. Should we make VersionForRepositoryFinder throw if

  • At least one of them doesn't exist?
  • The branch develop didn't initially branch off of master?

The above post use some lax wording regarding the constraints (eg. A feature branch may branch off from develop). Should we enforce such constraints

  • Make HotfixVersionFinder throw if the examined branch doesn't branch off of master?
  • Make ReleaseVersionFinder and FeatureVersionFinder throw if the examined branch doesn't branch off of develop?

The LibGitExtensions.GetBranch() performs a fetch from the first remote found if a specified branch cannot be found locally. Why do we need such behavior? In which context/environment is that triggered?

@andreasohlund
Copy link
Contributor

+1 for enforcing

That fetch happens on TeamCity mostly

@JakeGinnivan
Copy link
Contributor

This wont throw if develop does not exist, it will just assume GitHubFlow. Closing, we throw if master does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants