You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reintroduce withoutConcurrentExecution, because on some big page like the MariaDB one, it will just crash. In order to avoid the previous issue on vercel, we use React.cache({})` as our global request context so that it doesn't leak to other request with fluid compute.
It also disable resolvingAnchorText on InlineLink because with it, the request will just timeout if there is too many of them in a single page
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but when I think about it, we might still need to manage concurrency inside the use cache: imagine that the Node.js process receive 10 requests to generate pages in the same space, right now it'll result in 10 API requests to the same space for each of the top level requests.
I think we should manage concurrency at 2 levels:
Wrapping in the use cache: per-request using cache(() => {})
Wrapping the API call in the use cache: global in the process
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reintroduce
withoutConcurrentExecution, because on some big page like the MariaDB one, it will just crash. In order to avoid the previous issue on vercel, we useReact.cache({})` as our global request context so that it doesn't leak to other request with fluid compute.It also disable
resolvingAnchorTextonInlineLinkbecause with it, the request will just timeout if there is too many of them in a single page