sub-command to print multi-index entries (#301)

Byron · Byron · commit 6c10e097a432 · 2022-03-06T20:28:32.000+08:00
diff --git a/README.md b/README.md
@@ -39,6 +39,7 @@ Please see _'Development Status'_ for a listing of all crates and their capabili
           * [x] **info** - print information about the file
           * [x] **create** - create a multi-index from pack indices
           * [x] **verify** - check the file for consistency
+          * [x] **entries** - list all entries of the file
       - **index**
           * [x] [create](https://asciinema.org/a/352941) - create an index file by streaming a pack file as done during clone
              * [x] support for thin packs (as needed for fetch/pull)
diff --git a/git-worktree/src/index/mod.rs b/git-worktree/src/index/mod.rs
@@ -63,7 +63,6 @@ where
             }
             Err(err) => {
                 if options.keep_going {
-                    files.fail(format!("{}: {}", entry_path, err));
                     errors.push(ErrorRecord {
                         path: entry_path.into(),
                         error: Box::new(err),
diff --git a/gitoxide-core/src/pack/multi_index.rs b/gitoxide-core/src/pack/multi_index.rs
@@ -1,3 +1,4 @@
+use anyhow::bail;
 use std::{io::BufWriter, path::PathBuf, sync::atomic::AtomicBool};
 
 use crate::OutputFormat;
@@ -68,3 +69,14 @@ pub fn info(
     )?;
     Ok(())
 }
+
+pub fn entries(multi_index_path: PathBuf, format: OutputFormat, mut out: impl std::io::Write) -> anyhow::Result<()> {
+    if format != OutputFormat::Human {
+        bail!("Only human format is supported right now");
+    }
+    let file = git::odb::pack::multi_index::File::at(&multi_index_path)?;
+    for entry in file.iter() {
+        writeln!(out, "{} {} {}", entry.oid, entry.pack_index, entry.pack_offset)?;
+    }
+    Ok(())
+}
diff --git a/src/plumbing/main.rs b/src/plumbing/main.rs
@@ -378,6 +378,14 @@ pub fn main() -> Result<()> {
             )
             .map(|_| ()),
             pack::Subcommands::MultiIndex(multi_index::Platform { multi_index_path, cmd }) => match cmd {
+                pack::multi_index::Subcommands::Entries => prepare_and_run(
+                    "pack-multi-index-entries",
+                    verbose,
+                    progress,
+                    progress_keep_open,
+                    core::pack::multi_index::PROGRESS_RANGE,
+                    move |_progress, out, _err| core::pack::multi_index::entries(multi_index_path, format, out),
+                ),
                 pack::multi_index::Subcommands::Info => prepare_and_run(
                     "pack-multi-index-info",
                     verbose,
diff --git a/src/plumbing/options.rs b/src/plumbing/options.rs
@@ -267,6 +267,8 @@ pub mod pack {
 
         #[derive(Debug, clap::Subcommand)]
         pub enum Subcommands {
+            /// Display all entries of a multi-index: <oid> <pack-id> <pack-offset>
+            Entries,
             /// Print general information about a multi-index file
             Info,
             /// Verify a multi-index quickly without inspecting objects themselves

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ where`
`63`	`63`	`}`
`64`	`64`	`Err(err) => {`
`65`	`65`	`if options.keep_going {`
`66`		`- files.fail(format!("{}: {}", entry_path, err));`
`67`	`66`	`errors.push(ErrorRecord {`
`68`	`67`	`path: entry_path.into(),`
`69`	`68`	`error: Box::new(err),`