Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 970ec9b

Browse files
committed
make note about why we don't support passwords in URLs (#450)
Even though git does that.
1 parent 959c0bd commit 970ec9b

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

crate-status.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ Check out the [performance discussion][git-traverse-performance] as well.
143143
* [x] convert URL to string
144144
* [x] API documentation
145145
* [ ] Some examples
146-
146+
- **deviation**
147+
* URLs may not contain passwords, which cannot be represent here and if present, will be ignored.
148+
147149
### git-protocol
148150
* _abstract over protocol versions to allow delegates to deal only with a single way of doing things_
149151
* [x] **credentials**

git-url/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ pub use scheme::Scheme;
3030
///
3131
/// Additionally there is support for [deserialization][Url::from_bytes()] and serialization
3232
/// (_see the `Display::fmt()` implementation_).
33+
///
34+
/// Note that we do not support passing the password using the URL as it's likely leading to accidents.
3335
#[derive(PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
3436
#[cfg_attr(feature = "serde1", derive(serde::Serialize, serde::Deserialize))]
3537
pub struct Url {

0 commit comments

Comments
 (0)