change!: From<&[u8]> is now From<&BStr>

Byron · Byron · commit ffc4a85b9a91 · 2022-07-06T12:43:24.000+08:00
This better represents the meaning of the input, and simplifies
interactions with `git-config`.
diff --git a/git-url/src/lib.rs b/git-url/src/lib.rs
@@ -7,7 +7,7 @@ use std::{
     fmt::{self, Write},
 };
 
-use bstr::ByteSlice;
+use bstr::{BStr, ByteSlice};
 
 ///
 pub mod parse;
@@ -101,18 +101,18 @@ impl Url {
     }
 }
 
-impl TryFrom<&[u8]> for Url {
+impl TryFrom<&BStr> for Url {
     type Error = parse::Error;
 
-    fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
+    fn try_from(value: &BStr) -> Result<Self, Self::Error> {
         Self::from_bytes(value)
     }
 }
 
-impl<'a> TryFrom<std::borrow::Cow<'a, [u8]>> for Url {
+impl<'a> TryFrom<std::borrow::Cow<'a, BStr>> for Url {
     type Error = parse::Error;
 
-    fn try_from(value: std::borrow::Cow<'a, [u8]>) -> Result<Self, Self::Error> {
+    fn try_from(value: std::borrow::Cow<'a, BStr>) -> Result<Self, Self::Error> {
         Self::try_from(&*value)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ use std::{`
`7`	`7`	`fmt::{self, Write},`
`8`	`8`	`};`
`9`	`9`
`10`		`-use bstr::ByteSlice;`
	`10`	`+use bstr::{BStr, ByteSlice};`
`11`	`11`
`12`	`12`	`///`
`13`	`13`	`pub mod parse;`
`@@ -101,18 +101,18 @@ impl Url {`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`104`		`-impl TryFrom<&[u8]> for Url {`
	`104`	`+impl TryFrom<&BStr> for Url {`
`105`	`105`	`type Error = parse::Error;`
`106`	`106`
`107`		`- fn try_from(value: &[u8]) -> Result<Self, Self::Error> {`
	`107`	`+ fn try_from(value: &BStr) -> Result<Self, Self::Error> {`
`108`	`108`	`Self::from_bytes(value)`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`-impl<'a> TryFrom<std::borrow::Cow<'a, [u8]>> for Url {`
	`112`	`+impl<'a> TryFrom<std::borrow::Cow<'a, BStr>> for Url {`
`113`	`113`	`type Error = parse::Error;`
`114`	`114`
`115`		`- fn try_from(value: std::borrow::Cow<'a, [u8]>) -> Result<Self, Self::Error> {`
	`115`	`+ fn try_from(value: std::borrow::Cow<'a, BStr>) -> Result<Self, Self::Error> {`
`116`	`116`	`Self::try_from(&*value)`
`117`	`117`	`}`
`118`	`118`	`}`