Thanks to visit codestin.com
Credit goes to github.com

Skip to content

git-url: possible breaking change in public API surface between 0.7.0 and 0.7.3 #524

@jokeyrhyme

Description

Duplicates

  • I have searched the existing issues

Current behavior 😯

Howdie, thanks so much for sharing this project, it has been very useful for me <3

I wanted to ask about the version scheme in use for git-url, in particular: is it SemVer or some other scheme?

I have git-url = "0.7" in my Cargo.toml, and recently noticed that my builds started getting compiler errors, which seem to have started with the release of git-url 0.7.3

It seems that, among other changes, the new git-url version changed the function signature of git_url::parse() so that it no longer takes [u8], which I have been able to accommodate now in my project: https://gitlab.com/jokeyrhyme/tuning/-/merge_requests/26/diffs

It looks like this is the commit in question: f6506e0

Expected behavior 🤔

I suppose, if this were within a SemVer scheme, then bumping the version number of git-url to 0.8.0 might be an option

But, I'm a little rusty on pre-1.0 behaviour for version numbers :) I thought it was 0.MAJOR.MINOR , but 0.anything could also just not have the same API stability indication as 1.0 , so who know? :) 🤷

Again, thanks so much, I especially love the "serde1" feature flag for git-url, it's all terrific :) Thanks!

Steps to reproduce 🕹

  1. use git_url::parse() in git-url 0.7.0 without compiler errors
  2. update to git-url 0.7.3
  3. see new compiler errors: expected struct BStr, found slice [u8]

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions