ein t hours -fl based ODB panics#536
Merged
Merged
Conversation
…lti-threading is requested) (#536) This avoids duplicating test-runs.
It's supposed to happen when multiple threads, maybe, trigger the loading of packs at the same time. There are 15 packs to load here but apparently that doesn't manage to trigger it.
…ct resolution. (#536) Hard to understand, but the gist seems to be that looking up the base onbject recursively changes the snapshot layout which makes the follow-up lookup see a different index, which then won't have the original id. To circumvent, we will try to reuse it, but resort to a full search afterwards. Unfortunately there is no way to reproduce this, it's just the very special linux kernel pack I have here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The above invocation stresses the ODB in never before seen ways, apparently, as it extracts every single object ever seen. On repos that have multiple packs the parallel pack loading logic fails in ways that cause objects not to be found (reproducibly) or to trigger a panic.
Observations