tests: fix i18n format in Node 20.19 (#16398)

adamraine · web-flow · commit d8383d35e178 · 2025-03-19T16:56:15.000-07:00
diff --git a/.github/workflows/devtools.yml b/.github/workflows/devtools.yml
@@ -52,8 +52,8 @@ jobs:
         # 3) every change to file in Lighthouse repo important to running these tests.
         #
         # The number is how many times this hash key was manually updated to break the cache.
-        key: ${{ runner.os }}-12-${{ env.WEEK_OF_THE_YEAR }}-${{ hashFiles('cdt-test-hash.txt') }}
-        restore-keys: ${{ runner.os }}-12
+        key: ${{ runner.os }}-13-${{ env.WEEK_OF_THE_YEAR }}-${{ hashFiles('cdt-test-hash.txt') }}
+        restore-keys: ${{ runner.os }}-13
     - name: Set GHA_DEVTOOLS_CACHE_HIT
       if: steps.devtools-cache.outputs.cache-hit == 'true'
       run: echo "GHA_DEVTOOLS_CACHE_HIT=1" >> $GITHUB_ENV
diff --git a/report/test/renderer/i18n-formatter-test.js b/report/test/renderer/i18n-formatter-test.js
@@ -10,6 +10,8 @@ import {I18nFormatter} from '../../renderer/i18n-formatter.js';
 
 const NBSP = '\xa0';
 
+const [nodeMajor, nodeMinor] = process.version.replace('v', '').split('.').map(Number);
+
 describe('i18n formatter', () => {
   it('formats a number', () => {
     const i18n = new I18nFormatter('en');
@@ -139,9 +141,16 @@ describe('i18n formatter', () => {
     // Yes, this is actually backwards (s h d).
     i18n = new I18nFormatter('ar');
     /* eslint-disable no-irregular-whitespace */
-    assert.equal(i18n.formatDuration(60 * 1000), `١${NBSP}د`);
-    assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `١${NBSP}س ٥${NBSP}ث`);
-    assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `١ ي ٤ س ٥ ث`);
+    if (nodeMajor >= 20 && nodeMinor >= 19) {
+      assert.equal(i18n.formatDuration(60 * 1000), `1${NBSP}د`);
+      assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `1${NBSP}س 5${NBSP}ث`);
+      assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `1 ي 4 س 5 ث`);
+    } else {
+      assert.equal(i18n.formatDuration(60 * 1000), `١${NBSP}د`);
+      assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `١${NBSP}س ٥${NBSP}ث`);
+      assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `١ ي ٤ س ٥ ث`);
+    }
+
     /* eslint-enable no-irregular-whitespace */
   });
 
