Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f562893

Browse files
connorjclarkconnorjclark
committed
core(computed-artifacts): disallow undefined properties
1 parent 7938a6c commit f562893

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+181
-80
lines changed

‎core/audits/audit.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,8 @@ class Audit {
492492
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
493493
const gatherContext = artifacts.GatherContext;
494494
const {URL, SourceMaps} = artifacts;
495-
return {trace, devtoolsLog, gatherContext, settings: context.settings, URL, SourceMaps};
495+
// eslint-disable-next-line max-len
496+
return {trace, devtoolsLog, gatherContext, settings: context.settings, URL, SourceMaps, simulator: null};
496497
}
497498
}
498499

‎core/audits/byte-efficiency/offscreen-images.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ class OffscreenImages extends ByteEfficiencyAudit {
199199
const unfilteredResults = Array.from(resultsMap.values());
200200
// get the interactive time or fallback to getting the end of trace time
201201
try {
202-
const metricComputationData = {trace, devtoolsLog, gatherContext, settings, URL, SourceMaps};
202+
const metricComputationData =
203+
{trace, devtoolsLog, gatherContext, settings, URL, SourceMaps, simulator: null};
203204
const interactive = await Interactive.request(metricComputationData, context);
204205

205206
// use interactive to generate items

‎core/audits/byte-efficiency/unused-javascript.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class UnusedJavaScript extends ByteEfficiencyAudit {
9494
const script = artifacts.Scripts.find(s => s.scriptId === scriptId);
9595
if (!script) continue; // This should never happen.
9696

97-
const bundle = bundles.find(b => b.script.scriptId === scriptId);
97+
const bundle = bundles.find(b => b.script.scriptId === scriptId) ?? null;
9898
const unusedJsSummary =
9999
await UnusedJavascriptSummary.request({scriptId, scriptCoverage, bundle}, context);
100100
if (unusedJsSummary.wastedBytes === 0 || unusedJsSummary.totalBytes === 0) continue;

‎core/audits/largest-contentful-paint-element.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,11 @@ class LargestContentfulPaintElement extends Audit {
123123
const trace = artifacts.traces[Audit.DEFAULT_PASS];
124124
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
125125
const gatherContext = artifacts.GatherContext;
126-
const metricComputationData = {trace, devtoolsLog, gatherContext,
127-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
126+
const metricComputationData = {
127+
trace, devtoolsLog, gatherContext,
128+
settings: context.settings, URL: artifacts.URL,
129+
SourceMaps: artifacts.SourceMaps, simulator: null,
130+
};
128131

129132
const elementTable = this.makeElementTable(artifacts);
130133
if (!elementTable) {

‎core/audits/long-tasks.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ class LongTasks extends Audit {
193193

194194
const simulatorOptions = {devtoolsLog, settings: context.settings};
195195
const pageGraph =
196-
await PageDependencyGraph.request({settings, trace, devtoolsLog, URL, SourceMaps}, context);
196+
// eslint-disable-next-line max-len
197+
await PageDependencyGraph.request({settings, trace, devtoolsLog, URL, SourceMaps, fromTrace: false}, context);
197198
const simulator = await LoadSimulator.request(simulatorOptions, context);
198199
const simulation = simulator.simulate(pageGraph, {label: 'long-tasks-diagnostic'});
199200
for (const [node, timing] of simulation.nodeTimings.entries()) {

‎core/audits/metrics/first-contentful-paint.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ class FirstContentfulPaint extends Audit {
6565
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
6666
const gatherContext = artifacts.GatherContext;
6767
const metricComputationData = {trace, devtoolsLog, gatherContext,
68-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
68+
settings: context.settings, URL: artifacts.URL,
69+
SourceMaps: artifacts.SourceMaps, simulator: null,
70+
};
6971
const metricResult = await ComputedFcp.request(metricComputationData, context);
7072
const options = context.options[context.settings.formFactor];
7173

‎core/audits/metrics/interactive.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,11 @@ class InteractiveMetric extends Audit {
7070
const trace = artifacts.traces[Audit.DEFAULT_PASS];
7171
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
7272
const gatherContext = artifacts.GatherContext;
73-
const metricComputationData = {trace, devtoolsLog, gatherContext,
74-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
73+
const metricComputationData = {
74+
trace, devtoolsLog, gatherContext,
75+
settings: context.settings, URL: artifacts.URL,
76+
SourceMaps: artifacts.SourceMaps, simulator: null,
77+
};
7578
const metricResult = await Interactive.request(metricComputationData, context);
7679
const timeInMs = metricResult.timing;
7780
const options = context.options[context.settings.formFactor];

‎core/audits/metrics/largest-contentful-paint.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,11 @@ class LargestContentfulPaint extends Audit {
7373
const trace = artifacts.traces[Audit.DEFAULT_PASS];
7474
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
7575
const gatherContext = artifacts.GatherContext;
76-
const metricComputationData = {trace, devtoolsLog, gatherContext,
77-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
76+
const metricComputationData = {
77+
trace, devtoolsLog, gatherContext,
78+
settings: context.settings, URL: artifacts.URL,
79+
SourceMaps: artifacts.SourceMaps, simulator: null,
80+
};
7881

7982
const metricResult = await ComputedLcp.request(metricComputationData, context);
8083
const options = context.options[context.settings.formFactor];

‎core/audits/metrics/max-potential-fid.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,11 @@ class MaxPotentialFID extends Audit {
120120
const trace = artifacts.traces[Audit.DEFAULT_PASS];
121121
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
122122
const gatherContext = artifacts.GatherContext;
123-
const metricComputationData = {trace, devtoolsLog, gatherContext,
124-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
123+
const metricComputationData = {
124+
trace, devtoolsLog, gatherContext,
125+
settings: context.settings, URL: artifacts.URL,
126+
SourceMaps: artifacts.SourceMaps, simulator: null,
127+
};
125128
const metricResult = await ComputedFid.request(metricComputationData, context);
126129

127130
const processedTrace = await ProcessedTrace.request(trace, context);

‎core/audits/metrics/speed-index.js‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,11 @@ class SpeedIndex extends Audit {
6666
const trace = artifacts.traces[Audit.DEFAULT_PASS];
6767
const devtoolsLog = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
6868
const gatherContext = artifacts.GatherContext;
69-
const metricComputationData = {trace, devtoolsLog, gatherContext,
70-
settings: context.settings, URL: artifacts.URL, SourceMaps: artifacts.SourceMaps};
69+
const metricComputationData = {
70+
trace, devtoolsLog, gatherContext,
71+
settings: context.settings, URL: artifacts.URL,
72+
SourceMaps: artifacts.SourceMaps, simulator: null,
73+
};
7174
const metricResult = await ComputedSi.request(metricComputationData, context);
7275
const options = context.options[context.settings.formFactor];
7376

0 commit comments

Comments
 (0)