Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Define strongly typed function interface #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2023
Merged

feat: Define strongly typed function interface #186

merged 7 commits into from
May 23, 2023

Conversation

garethgeorge
Copy link
Contributor

@garethgeorge garethgeorge commented Apr 6, 2023 •
edited
Loading

Introduces a new Typed signature to the functions framework which provides automatic request deserialization and response serialization.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Apr 6, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 6 times, most recently from 64dfd62 to f210d68 Compare April 13, 2023 00:44
@garethgeorge garethgeorge changed the title feat: Define strongly typed function interface [do not submit] feat: Define strongly typed function interface Apr 13, 2023
@garethgeorge garethgeorge marked this pull request as ready for review April 13, 2023 20:26
@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 5 times, most recently from fd251c0 to ec1eee2 Compare April 14, 2023 22:11
@garethgeorge garethgeorge force-pushed the garethgeorge/typed branch 2 times, most recently from 157d722 to f640d96 Compare April 24, 2023 20:52
HKWinterhalter
HKWinterhalter reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@HKWinterhalter HKWinterhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

eamonnmcmanus
eamonnmcmanus reviewed Apr 27, 2023
View reviewed changes
@garethgeorge garethgeorge merged commit 5264e35 into master May 23, 2023
This was referenced May 23, 2023
Merged
Merged
Merged
@garethgeorge garethgeorge deleted the garethgeorge/typed branch May 23, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKWinterhalter HKWinterhalter HKWinterhalter left review comments

@janell-chen janell-chen janell-chen approved these changes

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees

@HKWinterhalter HKWinterhalter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garethgeorge @eamonnmcmanus @HKWinterhalter @janell-chen