fix: use ubuntu 22 for php 8.1 #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions conformance workflow to run PHP 8.1 on Ubuntu 22.04 and adjusts the PHP version matrix accordingly.
- Parameterize the runner OS using
matrix.osinstead of a hardcoded value. - Remove PHP 8.1 from the default matrix and re-add it explicitly on Ubuntu 22.04.
- Extend the PHP version matrix to include PHP 8.4.
Comments suppressed due to low confidence (3)
.github/workflows/conformance.yml:18
- [nitpick] For consistency and readability, add spaces after commas in the version array:
[ '8.2', '8.3', '8.4' ].
php-version: [ '8.2','8.3', '8.4' ]
.github/workflows/conformance.yml:17
- Consider defining both OSes in
matrix.os(['ubuntu-latest', 'ubuntu-22.04']) and usingexcludefor the unsupported PHP-OS combination to simplify the matrix.
os: [ 'ubuntu-latest' ]
.github/workflows/conformance.yml:20
- Add a brief comment explaining why PHP 8.1 requires
ubuntu-22.04, so future maintainers understand this special case.
- os: 'ubuntu-22.04'
maemayve
approved these changes
Jul 9, 2025
dixuswe
reviewed
Jul 9, 2025
| matrix: | ||
| php-version: [ '8.1','8.2','8.3' ] | ||
| os: [ 'ubuntu-latest' ] | ||
| php-version: [ '8.2','8.3', '8.4' ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.