Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow colons in Identity values #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 6 commits into from
May 22, 2019
Merged

Allow colons in Identity values #5029

chingor13 merged 6 commits into from
May 22, 2019

Conversation

@JesseLovelace
Copy link
Contributor

@JesseLovelace JesseLovelace commented Apr 26, 2019

This is to address internal bug 118884564. Identity is written for colons not to be allowed in the value, however colons are actually allowed in some legacy cases, like domain-scoped project IDs.

@JesseLovelace JesseLovelace requested a review from a team as a code owner April 26, 2019 21:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
chingor13
chingor13 requested changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still throw an IllegalArgumentException if there's more parts than we expect?

@codecov
Copy link

codecov bot commented Apr 29, 2019 •
edited
Loading

Codecov Report

Merging #5029 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5029      +/-   ##
============================================
- Coverage     50.38%   50.35%   -0.04%     
+ Complexity    23735    23684      -51     
============================================
  Files          2248     2242       -6     
  Lines        226478   226183     -295     
  Branches      24954    24961       +7     
============================================
- Hits         114107   113886     -221     
+ Misses       103778   103694      -84     
- Partials       8593     8603      +10
Impacted Files Coverage Δ Complexity Δ
...-core/src/main/java/com/google/cloud/Identity.java 86.27% <100%> (-3.93%) 19 <2> (-1)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 50% <0%> (-12%) 11% <0%> (-8%)
...e/cloud/vision/v1/stub/GrpcImageAnnotatorStub.java 83.05% <0%> (-5.5%) 10% <0%> (-2%)
...rc/main/java/com/google/cloud/firestore/Query.java 87.93% <0%> (-4.75%) 86% <0%> (-4%)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 86.63% <0%> (-2.5%) 23% <0%> (ø)
...oud/vision/v1/stub/ImageAnnotatorStubSettings.java 83.05% <0%> (-2.41%) 12% <0%> (-3%)
...om/google/cloud/firestore/CollectionReference.java 47.5% <0%> (-1.29%) 9% <0%> (-1%)
...java/com/google/cloud/firestore/FirestoreImpl.java 82.2% <0%> (-0.84%) 19% <0%> (-3%)
...loud/vision/v1/stub/ProductSearchStubSettings.java 81.87% <0%> (ø) 29% <0%> (ø) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d36e4...4b3e158. Read the comment docs.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2019
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2019
@chingor13 chingor13 merged commit fff25ba into master May 22, 2019
@chingor13 chingor13 deleted the allowcolonsinids branch May 22, 2019 20:51
@chingor13 chingor13 mentioned this pull request May 22, 2019
Merged
@athakor athakor mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

@kolea2 kolea2 Awaiting requested review from kolea2

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JesseLovelace @chingor13 @googlebot @yoshi-automation @yoshi-kokoro