Update maven config to include *.proto files in jars #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build-helper-maven-plugin to `com.google.api.grpc:google-api-grpc` thereby updating the config for all `proto-*` modules such that when their jars are built they will now include the `*.proto`. This allows dependents to already have the proto files on their classpath when they are defining/generating their own protos. Add build-helper-maven-plugin config to `com.google.cloud:google-cloud-firestore` for its test resources as proto is defined for the conformance tests.
Codecov Report
@@ Coverage Diff @@
## master #5208 +/- ##
============================================
- Coverage 50.42% 50.41% -0.01%
Complexity 23796 23796
============================================
Files 2251 2251
Lines 226836 226836
Branches 24966 24966
============================================
- Hits 114371 114368 -3
- Misses 103858 103861 +3
Partials 8607 8607
Continue to review full report at Codecov.
|
chingor13
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add build-helper-maven-plugin to
com.google.api.grpc:google-api-grpcthereby updating the config for all
proto-*modules such that whentheir jars are built they will now include the
*.proto. This allowsdependents to already have the proto files on their classpath when they
are defining/generating their own protos.
Add build-helper-maven-plugin config to
com.google.cloud:google-cloud-firestorefor its test resources asproto is defined for the conformance tests.