Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Firestore:deprecated warnings removed #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Jun 11, 2019
Merged

Firestore:deprecated warnings removed #5459

sduskis merged 1 commit into from
Jun 11, 2019

Conversation

@abhinav-qlogic
Copy link

@abhinav-qlogic abhinav-qlogic commented Jun 11, 2019

Works towards #4384

@abhinav-qlogic abhinav-qlogic requested a review from a team as a code owner June 11, 2019 11:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #5459 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5459      +/-   ##
============================================
+ Coverage     50.81%   50.82%   +<.01%     
  Complexity    24173    24173              
============================================
  Files          2271     2271              
  Lines        229900   229906       +6     
  Branches      25005    25005              
============================================
+ Hits         116829   116841      +12     
+ Misses       104440   104434       -6     
  Partials       8631     8631
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/firestore/DocumentReference.java 70.93% <100%> (+0.34%) 30 <0> (ø) ⬇️
...om/google/cloud/firestore/CollectionReference.java 50% <100%> (+1.21%) 10 <0> (ø) ⬇️
...n/java/com/google/cloud/firestore/Transaction.java 97.77% <100%> (+0.15%) 11 <0> (ø) ⬇️
...java/com/google/cloud/firestore/UpdateBuilder.java 95.23% <100%> (+0.02%) 70 <0> (ø) ⬇️
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️
.../java/com/google/cloud/testing/CommandWrapper.java 96.96% <0%> (+9.09%) 13% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffeb34...20a2e5e. Read the comment docs.

@sduskis sduskis merged commit 68de41e into googleapis:master Jun 11, 2019
This was referenced Jun 12, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinav-qlogic @sduskis @googlebot @pmakani @yoshi-kokoro