Bigtable: remove integration tests from the default failsafe execution #5955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bug introduced in googleapis#5756. When integration profiles were introduced, I forgot to remove the test from the default execution of the failsafe plugin. The new way integration tests are run are via profile activation: by default the bigtable-emulator-it profile is active.
Codecov Report
@@ Coverage Diff @@
## master #5955 +/- ##
=========================================
Coverage 46.79% 46.79%
- Complexity 25648 25663 +15
=========================================
Files 2456 2456
Lines 267613 267613
Branches 30563 30558 -5
=========================================
Hits 125241 125241
Misses 133113 133113
Partials 9259 9259Continue to review full report at Codecov.
|
kolea2
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug introduced in #5756. When integration profiles were introduced,
I forgot to remove the test from the default execution of the failsafe plugin.
The new way integration tests are run are via profile activation: by default
the bigtable-emulator-it profile is active.