Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid hardcoding endpoint URL in grpc_gcp unit tests. #5893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

Avoid hardcoding endpoint URL in grpc_gcp unit tests. #5893

merged 1 commit into from
Sep 7, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 6, 2018

That bit of configuration is a class attribute, and may be changed, e.g. to point at non-production endpoints.

@tseaver
Don't hardcode endpoint URL in grpc_gcp unit tests.
f5b5849 
That bit of configuration is a class attribute, and may be changed, e.g.
to point at non-production endpoints.
@tseaver tseaver added testing api: spanner Issues related to the Spanner API. labels Sep 6, 2018
@tseaver tseaver requested a review from theacodes September 6, 2018 16:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2018
@tseaver tseaver changed the title Don't hardcode endpoint URL in grpc_gcp unit tests. Avoid hardcoding endpoint URL in grpc_gcp unit tests. Sep 6, 2018
@tseaver tseaver requested a review from mcdonc September 6, 2018 18:32
@tseaver tseaver merged commit e7f43ec into master Sep 7, 2018
@tseaver tseaver deleted the spanner-use_class_attr_for_target branch September 7, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonc mcdonc Awaiting requested review from mcdonc

1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @theacodes @googlebot