Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Speech sample cleanup #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2020
Merged

Speech sample cleanup #2628

merged 6 commits into from
Feb 28, 2020

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Dec 17, 2019

No description provided.

@nnegrey nnegrey requested a review from a team as a code owner December 17, 2019 19:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2019
@nnegrey nnegrey mentioned this pull request Dec 17, 2019
Closed
@nnegrey
Copy link
Contributor Author

nnegrey commented Dec 17, 2019

It appears PyAudio can't be built on the Kokoro environment, ideas?
@kurtisvg @leahecole

PyAudio is used for getting audio from the microphone.

@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 17, 2019 •
edited
Loading

It appears PyAudio can't be built on the Kokoro environment, ideas?
@kurtisvg @leahecole

PyAudio is used for getting audio from the microphone.

@nnegrey - Possibly we need to install a package - sudo apt-get install libasound-dev

@dmahugh
Copy link
Contributor

dmahugh commented Jan 14, 2020

@nnegrey - is this still in work, or should we close it? (Note suggested fix from @kurtisvg above regarding installing libasound-dev.)

@nnegrey
Copy link
Contributor Author

nnegrey commented Jan 15, 2020

I'm assuming that above fix needs to be done on the Kokoro instance or the testing script?

@busunkim96
Copy link
Contributor

You can add that the package to the docker image used for testing: https://github.com/googleapis/testing-infra-docker/blob/master/python/googleapis/python-multi/Dockerfile

@czahedi
Copy link
Contributor

czahedi commented Feb 21, 2020

Hiya folks,

We got a customer issue related to one of the fixes this PR is trying to implement. Do we have a solution to having PyAudio work with Kokoro?

Thanks,

Cameron

@nnegrey nnegrey mentioned this pull request Feb 21, 2020
Closed
@busunkim96 busunkim96 mentioned this pull request Feb 27, 2020
Merged
@busunkim96
Copy link
Contributor

Opened googleapis/testing-infra-docker#55 to add package PyAudio needs to install correctly.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@busunkim96 busunkim96 requested a review from leahecole February 27, 2020 22:36
@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 27, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json

@busunkim96 busunkim96 merged commit 570453c into master Feb 28, 2020
@busunkim96 busunkim96 deleted the speech-sample-cleanup branch February 28, 2020 23:09
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
@nnegrey
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
928e17b 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
3be3984 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
@telpirion telpirion mentioned this pull request Jan 13, 2023
Merged
8 tasks
telpirion pushed a commit that referenced this pull request Jan 13, 2023
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](#2628)
9bd7e8d 
* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
@nnegrey @dandhlee
Speech sample cleanup [(#2628)](#2628)
273210f 
* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@nnegrey @telpirion
Speech sample cleanup [(#2628)](#2628)
3a27793 
* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
dd1f8d3 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
1ca411e 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
10bdb72 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
@nnegrey @busunkim96
Speech sample cleanup [(#2628)](GoogleCloudPlatform/python-docs-sampl…
959ff21 
…es#2628)

* Remove similar samples, update streaming limit

* Update to v1 library

* Fix requirements.txt

* Update library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees

@dmahugh dmahugh

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nnegrey @kurtisvg @dmahugh @busunkim96 @czahedi @googlebot @kokoro-team