Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Organize speech samples into grpc vs REST #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2016
Merged

Organize speech samples into grpc vs REST #502

merged 1 commit into from
Sep 7, 2016

Conversation

jerjou
Copy link
Contributor

@jerjou jerjou commented Sep 6, 2016

Addresses #437

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016
@theacodes
Copy link
Contributor

Much cleaner, but why not go ahead and:

speech_async_rest.py -> async.py
speech_async_grpc.py -> async.py

etc.

@puneith
Copy link
Contributor

puneith commented Sep 6, 2016

+1 on renaming

@jerjou jerjou force-pushed the speech-hygiene branch 3 times, most recently from c242077 to 7f9dfbb Compare September 6, 2016 21:58
@jerjou
Copy link
Contributor Author

jerjou commented Sep 6, 2016

Hrm... what about speech_grpc.py? :-)

@jerjou
Copy link
Contributor Author

jerjou commented Sep 6, 2016

Went with transcribe_* LMKWYT

@theacodes
Copy link
Contributor

LGTM. :)

@theacodes theacodes merged commit 50afc9f into master Sep 7, 2016
@theacodes theacodes deleted the speech-hygiene branch September 7, 2016 16:54
@jonasrla
Copy link

Hello,

This link is broken https://goo.gl/EPjAup

@jerjou
Copy link
Contributor Author

jerjou commented Sep 13, 2016

Thanks! Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theacodes theacodes

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jerjou @theacodes @puneith @jonasrla @googlebot