Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for blade directives and component aliases #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2020
Merged

Add support for blade directives and component aliases #151

merged 3 commits into from
Jun 27, 2020

Conversation

shovhan
Copy link
Contributor

@shovhan shovhan commented Apr 30, 2020 •
edited
Loading

This pull request add support for directives and component aliases.
It is now possible to use Blade::component('view.name', 'component') and Blade::directive('name', function () {}) with 'htmlmin.blade' config set to true.

@johannitsa
Copy link

@srmklive can you merge this, please?

@shovhan
Copy link
Contributor Author

shovhan commented Jun 16, 2020 •
edited
Loading

When using Laravel 7 components with the htmlmin.blade configuration set to true, a 'Unable to locate a class or view for component ' error may occur

Last сommit (d8e9749) solves this error

@srmklive srmklive merged commit d0e21a5 into HTMLMin:master Jun 27, 2020
@u01jmg3
Copy link

u01jmg3 commented Oct 12, 2020

@shovhan

Laravel-HTMLMin/src/HTMLMinServiceProvider.php

Lines 165 to 170 in e67fe97

protected function registerMinifyCompiler()
{
$previousCompiler = $this->app->make('view')
->getEngineResolver()
->resolve('blade')
->getCompiler();

I am getting the following error from Laravel when running php artisan package:discover --ansi due to the code above. It is caused by 0aca66d.

In Container.php line 811:
  Target class [view] does not exist.

In Container.php line 809:
  Class view does not exist

@u01jmg3
Copy link

u01jmg3 commented Jan 3, 2022 •
edited
Loading

The merged PR #162 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shovhan @johannitsa @u01jmg3 @srmklive