fix: async model call prints should only occur if PDL_VERBOSE_ASYNC env is set

starpit · starpit · commit e406a5a69f98 · 2025-03-21T18:03:44.000-04:00
Signed-off-by: Nick Mitchell &lt;nickm@us.ibm.com&gt;
diff --git a/pdl-live-react/src/view/term/RunTerminal.tsx b/pdl-live-react/src/view/term/RunTerminal.tsx
@@ -83,6 +83,9 @@ export default function RunTerminal({
       // spawn shell
       const pty = spawn(cmd, args, {
         cwd,
+        env: {
+          PDL_VERBOSE_ASYNC: "true",
+        },
         cols: term.cols,
         rows: term.rows,
       })
diff --git a/src/pdl/pdl_llms.py b/src/pdl/pdl_llms.py
@@ -1,4 +1,5 @@
 # pylint: disable=import-outside-toplevel
+from os import environ
 import asyncio
 import threading
 from concurrent.futures import Future
@@ -87,7 +88,8 @@ def generate_text(
         messages: ModelInput,
         parameters: dict[str, Any],
     ) -> tuple[LazyMessage, PdlLazy[Any]]:
-        print(f"Asynchronous model call started to {model_id}", file=stderr)
+        if "PDL_VERBOSE_ASYNC" in environ:
+            print(f"Asynchronous model call started to {model_id}", file=stderr)
         # global _BACKGROUND_TASKS
         future = asyncio.run_coroutine_threadsafe(
             LitellmModel.async_generate_text(
@@ -130,22 +132,23 @@ def update_end_nanos(future):
                     else 0
                 )
                 exec_nanos = block.pdl__timing.end_nanos - start
-                print(
-                    f"Asynchronous model call to {model_id} completed in {(exec_nanos)/1000000}ms",
-                    file=stderr,
-                )
-                msg = future.result()[0]
-                if msg["content"] is not None:
-                    from termcolor import colored
-
-                    from .pdl_ast import BlockKind
-                    from .pdl_scheduler import color_of
-
+                if "PDL_VERBOSE_ASYNC" in environ:
                     print(
-                        colored(msg["content"], color=color_of(BlockKind.MODEL)),
+                        f"Asynchronous model call to {model_id} completed in {(exec_nanos)/1000000}ms",
                         file=stderr,
                     )
-                    print("\n", file=stderr)
+                    msg = future.result()[0]
+                    if msg["content"] is not None:
+                        from termcolor import colored
+
+                        from .pdl_ast import BlockKind
+                        from .pdl_scheduler import color_of
+
+                        print(
+                            colored(msg["content"], color=color_of(BlockKind.MODEL)),
+                            file=stderr,
+                        )
+                        print("\n", file=stderr)
 
         future.add_done_callback(update_end_nanos)
 
