Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ddeb9fc

Browse files
committed
Added generic reprs for all missing vega* specs
1 parent 8172677 commit ddeb9fc

File tree

5 files changed

+56
-5
lines changed

5 files changed

+56
-5
lines changed

NAMESPACE

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,11 @@ S3method(repr_text,shiny.tag.list)
9191
S3method(repr_text,ts)
9292
S3method(repr_vdom1,default)
9393
S3method(repr_vega4,default)
94+
S3method(repr_vega5,default)
9495
S3method(repr_vegalite2,default)
9596
S3method(repr_vegalite2,vegalite)
97+
S3method(repr_vegalite3,default)
98+
S3method(repr_vegalite4,default)
9699
export(format2repr)
97100
export(html_dependencies)
98101
export(mime2repr)
@@ -112,7 +115,10 @@ export(repr_svg)
112115
export(repr_text)
113116
export(repr_vdom1)
114117
export(repr_vega4)
118+
export(repr_vega5)
115119
export(repr_vegalite2)
120+
export(repr_vegalite3)
121+
export(repr_vegalite4)
116122
importFrom(base64enc,dataURI)
117123
importFrom(grDevices,cairo_pdf)
118124
importFrom(grDevices,dev.off)

R/generics.r

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,22 @@ repr_vegalite2 <- function(obj, ...) UseMethod('repr_vegalite2', obj)
151151
repr_vegalite2.default <- function(obj, ...) NULL
152152

153153

154+
#' @name repr-generics
155+
#' @export
156+
repr_vegalite3 <- function(obj, ...) UseMethod('repr_vegalite3', obj)
157+
#' @name repr-generics
158+
#' @export
159+
repr_vegalite3.default <- function(obj, ...) NULL
160+
161+
162+
#' @name repr-generics
163+
#' @export
164+
repr_vegalite4 <- function(obj, ...) UseMethod('repr_vegalite4', obj)
165+
#' @name repr-generics
166+
#' @export
167+
repr_vegalite4.default <- function(obj, ...) NULL
168+
169+
154170
#' @name repr-generics
155171
#' @export
156172
repr_vega4 <- function(obj, ...) UseMethod('repr_vega4', obj)
@@ -159,6 +175,14 @@ repr_vega4 <- function(obj, ...) UseMethod('repr_vega4', obj)
159175
repr_vega4.default <- function(obj, ...) NULL
160176

161177

178+
#' @name repr-generics
179+
#' @export
180+
repr_vega5 <- function(obj, ...) UseMethod('repr_vega5', obj)
181+
#' @name repr-generics
182+
#' @export
183+
repr_vega5.default <- function(obj, ...) NULL
184+
185+
162186
#' Lists mapping mime types (\code{mime2repr}) or format names (\code{format2repr}) to \code{repr} functions
163187
#'
164188
#' @format Lists mapping mime/name to function
@@ -180,7 +204,10 @@ mime2repr <- list(
180204
'application/vdom.v1+json' = repr_vdom1,
181205
'application/vnd.plotly.v1+json' = repr_plotly1,
182206
'application/vnd.vegalite.v2+json' = repr_vegalite2,
207+
'application/vnd.vegalite.v3+json' = repr_vegalite3,
208+
'application/vnd.vegalite.v4+json' = repr_vegalite4,
183209
'application/vnd.vega.v4+json' = repr_vega4,
210+
'application/vnd.vega.v5+json' = repr_vega5,
184211
'application/pdf' = repr_pdf,
185212
'image/png' = repr_png,
186213
'image/jpeg' = repr_jpg,
@@ -189,5 +216,5 @@ mime2repr <- list(
189216
#' @name *2repr
190217
#' @export
191218
format2repr <- sapply(
192-
c('text', 'html', 'markdown', 'latex', 'javascript', 'json', 'geojson', 'vdom1', 'plotly1', 'vegalite2', 'vega4', 'pdf', 'png', 'jpg', 'svg'),
219+
c('text', 'html', 'markdown', 'latex', 'javascript', 'json', 'geojson', 'vdom1', 'plotly1', paste0('vegalite', 2:4), paste0('vega', 4:5), 'pdf', 'png', 'jpg', 'svg'),
193220
function(n) get(paste0('repr_', n)))

R/repr_vega.r

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
#' @param obj The \link[vegalite]{vegalite} plot to create a representation for
44
#' @param ... ignored
55
#'
6-
#' @name repr_vega(4/lite2).*
6+
#' @name repr_vega*
77
NULL
88

9-
#' @name repr_vega(4/lite2).*
9+
#' @name repr_vega*
1010
#' @export
1111
repr_vegalite2.vegalite <- function(obj, ...) obj$x

man/repr-generics.Rd

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)