[Java] Improve validation of valueRef on fields.

mjpt777 · mjpt777 · commit 66cc7f25cebd · 2015-12-07T20:58:44.000Z
diff --git a/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/Field.java b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/Field.java
@@ -110,14 +110,14 @@ public void validate(final Node node)
                 final String valueRefType = valueRef.substring(0, periodIndex);
                 if (!valueRefType.equals(type.name()))
                 {
-                    handleError(node, "valueRef Enum type not found: " + valueRefType);
+                    handleError(node, "valueRef for Enum name not found: " + valueRefType);
                 }
 
                 final String validValueName = valueRef.substring(periodIndex + 1);
                 final EnumType enumType = (EnumType)type;
                 if (null == enumType.getValidValue(validValueName))
                 {
-                    handleError(node, "valueRef Valid value name not found: " + validValueName);
+                    handleError(node, "valueRef for validValue name not found: " + validValueName);
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -110,14 +110,14 @@ public void validate(final Node node)`
`110`	`110`	`final String valueRefType = valueRef.substring(0, periodIndex);`
`111`	`111`	`if (!valueRefType.equals(type.name()))`
`112`	`112`	`{`
`113`		`- handleError(node, "valueRef Enum type not found: " + valueRefType);`
	`113`	`+ handleError(node, "valueRef for Enum name not found: " + valueRefType);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`final String validValueName = valueRef.substring(periodIndex + 1);`
`117`	`117`	`final EnumType enumType = (EnumType)type;`
`118`	`118`	`if (null == enumType.getValidValue(validValueName))`
`119`	`119`	`{`
`120`		`- handleError(node, "valueRef Valid value name not found: " + validValueName);`
	`120`	`+ handleError(node, "valueRef for validValue name not found: " + validValueName);`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`	`}`