Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 420a1ff

Browse files
fix: upload command
1 parent ee76b27 commit 420a1ff

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

README.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,20 @@ For more info, visit [Instabug.com](https://www.instabug.com).
2525
```bash
2626
yarn add instabug-reactnative
2727
```
28+
2. if you are using expo you need to add `instabug-reactnative` plugin to `app.json`:
29+
```json
30+
"plugins" : [
31+
[
32+
"instabug-reactnative",
33+
{
34+
// optional that add Mic,Photo permission on iOS and FOREGROUND_SERVICE_MEDIA_PROJECTION on android
35+
"addScreenRecordingBugReportingPermission": true
36+
}
37+
]
38+
]
39+
```
2840

29-
2. CocoaPods on iOS needs this extra step:
41+
3. CocoaPods on iOS needs this extra step:
3042

3143
```bash
3244
cd ios && pod install && cd ..

plugin/src/withInstabug.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { withInstabugIOS } from './withInstabugIOS';
77
export interface PluginProps {
88
name?: string;
99
forceUploadSourceMaps?: boolean;
10-
addMediaUploadBugReportingPermission?: boolean;
10+
addScreenRecordingBugReportingPermission?: boolean;
1111
}
1212

1313
const instabugPackage = require('../../package.json') as {
@@ -16,13 +16,13 @@ const instabugPackage = require('../../package.json') as {
1616
};
1717

1818
const withInstabugPlugin: ConfigPlugin<PluginProps> = (config, props = {}) => {
19-
const { forceUploadSourceMaps = false, addMediaUploadBugReportingPermission = false } = props;
19+
const { forceUploadSourceMaps = false, addScreenRecordingBugReportingPermission = false } = props;
2020

2121
const sharedProps = {
2222
...props,
2323
name: instabugPackage.name,
2424
forceUploadSourceMaps,
25-
addMediaUploadBugReportingPermission,
25+
addScreenRecordingBugReportingPermission,
2626
};
2727

2828
let updatedConfig = config;

plugin/src/withInstabugAndroid.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const withInstabugAndroid: ConfigPlugin<PluginProps> = (config, props) =>
2727
});
2828

2929
// Inject the permission if requested
30-
if (props.addMediaUploadBugReportingPermission) {
30+
if (props.addScreenRecordingBugReportingPermission) {
3131
config = withAndroidManifest(config, (configAndroid) => {
3232
const manifest = configAndroid.modResults;
3333

plugin/src/withInstabugIOS.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export const withInstabugIOS: ConfigPlugin<PluginProps> = (config, props) => {
3535
});
3636

3737
// Add media permissions to Info.plist if enabled
38-
if (props.addMediaUploadBugReportingPermission) {
38+
if (props.addScreenRecordingBugReportingPermission) {
3939
const instabugConfig = config.extra?.instabug ?? {};
4040

4141
const microphonePermission =

0 commit comments

Comments
 (0)