fix(eslint-plugin): [no-deprecated] report on deprecated variables used inside dynamic imports (typescript-eslint#10261)

auvred · web-flow · commit 1e633c7381a2 · 2024-11-03T03:37:08.000-08:00
diff --git a/packages/eslint-plugin/src/rules/no-deprecated.ts b/packages/eslint-plugin/src/rules/no-deprecated.ts
@@ -130,7 +130,6 @@ export default createRule({
           case AST_NODE_TYPES.ExportDefaultDeclaration:
           case AST_NODE_TYPES.ExportNamedDeclaration:
           case AST_NODE_TYPES.ImportDeclaration:
-          case AST_NODE_TYPES.ImportExpression:
             return true;
 
           case AST_NODE_TYPES.ArrowFunctionExpression:
diff --git a/packages/eslint-plugin/tests/rules/no-deprecated.test.ts b/packages/eslint-plugin/tests/rules/no-deprecated.test.ts
@@ -429,6 +429,22 @@ ruleTester.run('no-deprecated', rule, {
         },
       ],
     },
+    {
+      code: `
+        /** @deprecated */ const a = 'foo';
+        import(\`./path/\${a}.js\`);
+      `,
+      errors: [
+        {
+          column: 26,
+          data: { name: 'a' },
+          endColumn: 27,
+          endLine: 3,
+          line: 3,
+          messageId: 'deprecated',
+        },
+      ],
+    },
     {
       code: `
         declare function log(...args: unknown): void;
