names imported with as but renamed to a private name are not exported

JelleZijlstra · JelleZijlstra · commit 3a67d5361032 · 2017-05-22T23:28:02.000-07:00
diff --git a/tests/test.py b/tests/test.py
@@ -56,7 +56,8 @@ def test_get_stub_names(self) -> None:
         names = get_stub_names('simple', version=(3, 5))
         self.assertEqual(set(names.keys()), {
             'var', 'old_var', 'func', 'async_func', 'Cls', '_private',
-            'exported', 'unexported', 'other', 'multiple', 'assignment', 'new_name'
+            'exported', 'unexported', 'other', 'multiple', 'assignment', 'new_name',
+            '_made_private',
         })
 
         # Simple assignments
@@ -76,6 +77,9 @@ def test_get_stub_names(self) -> None:
         self.assertEqual(names['unexported'].ast, typeshed_client.ImportedName(path, 'unexported'))
         self.check_nameinfo(names, 'new_name', typeshed_client.ImportedName)
         self.assertEqual(names['new_name'].ast, typeshed_client.ImportedName(path, 'renamed'))
+        self.check_nameinfo(names, '_made_private', typeshed_client.ImportedName, is_exported=False)
+        self.assertEqual(names['_made_private'].ast,
+                         typeshed_client.ImportedName(path, 'made_private'))
 
         # Functions
         self.check_nameinfo(names, 'func', ast3.FunctionDef)
diff --git a/tests/typeshed/stdlib/3/other.pyi b/tests/typeshed/stdlib/3/other.pyi
@@ -1,3 +1,4 @@
 unexported: int
 exported: int
 renamed: int
+made_private: int
diff --git a/tests/typeshed/stdlib/3/simple.pyi b/tests/typeshed/stdlib/3/simple.pyi
@@ -1,5 +1,5 @@
 import other
-from other import unexported, exported as exported, renamed as new_name
+from other import unexported, exported as exported, renamed as new_name, made_private as _made_private
 
 _private: int
 
diff --git a/typeshed_client/parser.py b/typeshed_client/parser.py
@@ -152,7 +152,8 @@ def visit_ImportFrom(self, node: ast3.ImportFrom) -> Iterable[NameInfo]:
             source_module = ModulePath(self.module_name[:-node.level] + module)
         for alias in node.names:
             if alias.asname is not None:
-                yield NameInfo(alias.asname, True, ImportedName(source_module, alias.name))
+                is_exported = not alias.asname.startswith('_')
+                yield NameInfo(alias.asname, is_exported, ImportedName(source_module, alias.name))
             else:
                 yield NameInfo(alias.name, False, ImportedName(source_module, alias.name))
 
