checkpatch: warn on unnecessary parentheses around references of foo->bar

JoePerches · sfrothwell · commit 81ae54284952 · 2014-07-03T08:43:45.000+10:00
Parentheses around &amp;(foo-&gt;bar) and *(foo-&gt;bar) are unnecessary.  Emit a
--strict only message on these uses.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -3491,6 +3491,14 @@ sub process {
 			}
 		}
 
+# check unnecessary parentheses around addressof/dereference single $Lvals
+# ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
+
+		while ($line =~ /(?:[^&]&\s*|\*)\(\s*($Ident\s*(?:$Member\s*)+)\s*\)/g) {
+			CHK("UNNECESSARY_PARENTHESES",
+			    "Unnecessary parentheses around $1\n" . $herecurr);
+		    }
+
 #goto labels aren't indented, allow a single space however
 		if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
 		   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {

Original file line number	Diff line number	Diff line change
`@@ -3491,6 +3491,14 @@ sub process {`
`3491`	`3491`	`}`
`3492`	`3492`	`}`
`3493`	`3493`
	`3494`	`+# check unnecessary parentheses around addressof/dereference single $Lvals`
	`3495`	`+# ie: &(foo->bar) should be &foo->bar and (foo->bar) should be foo->bar`
	`3496`	`+`
	`3497`	`+ while ($line =~ /(?:[^&]&\s\|\)\(\s($Ident\s(?:$Member\s)+)\s\)/g) {`
	`3498`	`+ CHK("UNNECESSARY_PARENTHESES",`
	`3499`	`+ "Unnecessary parentheses around $1\n" . $herecurr);`
	`3500`	`+ }`
	`3501`	`+`
`3494`	`3502`	`#goto labels aren't indented, allow a single space however`
`3495`	`3503`	`if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and`
`3496`	`3504`	`!($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {`